helm-operator upgrade releases revision in each sync loop

[ejimz]

Describe the bug

I have several helm releases upgrading their revision in each sync loop without new changes.

To Reproduce

Steps to reproduce the behaviour:

1. Add cert-manager helm release to a git repo.
2. Configure helm-operator/flux with this git repo

Expected behavior

The helm release must me upgraded only if there are new changes.

Logs
helm history cert-manager
`REVISION UPDATED STATUS CHART APP VERSION DESCRIPTION

23789 Thu Oct 8 11:22:51 2020 superseded cert-manager-v0.15.0 v0.15.0 Upgrade complete

23790 Thu Oct 8 11:26:02 2020 superseded cert-manager-v0.15.0 v0.15.0 Upgrade complete

23791 Thu Oct 8 11:29:02 2020 superseded cert-manager-v0.15.0 v0.15.0 Upgrade complete

23792 Thu Oct 8 11:32:03 2020 deployed cert-manager-v0.15.0 v0.15.0 Upgrade complete

`

helm-operator pod log
{"caller":"release.go:79","component":"release","helmVersion":"v3","info":"starting sync run","release":"cert-manager","resource":"ingress-nginx:helmrelease/cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:42.790739788Z"} {"action":"upgrade","caller":"release.go:353","component":"release","helmVersion":"v3","info":"running upgrade","release":"cert-manager","resource":"ingress-nginx:helmrelease/cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:46.704461953Z"} {"caller":"helm.go:69","component":"helm","info":"preparing upgrade for cert-manager","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:46.895916111Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"resetting values to the chart's original version","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:47.005563278Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"performing update for cert-manager","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:50.591352195Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"creating upgraded release for cert-manager","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:51.394408116Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"checking 37 resources for changes","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:54.113855991Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ServiceAccount \"cert-manager-cainjector\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:54.190350853Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ServiceAccount \"cert-manager\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:54.198097964Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ServiceAccount \"cert-manager-webhook\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:54.20504916Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for CustomResourceDefinition \"certificaterequests.cert-manager.io\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:54.302108519Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for CustomResourceDefinition \"certificates.cert-manager.io\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:54.404792041Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for CustomResourceDefinition \"challenges.acme.cert-manager.io\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:54.505731384Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for CustomResourceDefinition \"clusterissuers.cert-manager.io\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:54.597040615Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for CustomResourceDefinition \"issuers.cert-manager.io\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:54.707873314Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for CustomResourceDefinition \"orders.acme.cert-manager.io\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:54.803104191Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ClusterRole \"cert-manager-cainjector\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:54.902335592Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ClusterRole \"cert-manager-controller-issuers\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:54.995478176Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ClusterRole \"cert-manager-controller-clusterissuers\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.002347025Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ClusterRole \"cert-manager-controller-certificates\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.009341576Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ClusterRole \"cert-manager-controller-orders\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.016198796Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ClusterRole \"cert-manager-controller-challenges\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.02349792Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ClusterRole \"cert-manager-controller-ingress-shim\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.03032586Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ClusterRole \"cert-manager-view\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.041579464Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ClusterRole \"cert-manager-edit\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.055121919Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ClusterRoleBinding \"cert-manager-cainjector\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.0648887Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ClusterRoleBinding \"cert-manager-controller-issuers\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.075612634Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ClusterRoleBinding \"cert-manager-controller-clusterissuers\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.08834469Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ClusterRoleBinding \"cert-manager-controller-certificates\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.097814998Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ClusterRoleBinding \"cert-manager-controller-orders\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.108116268Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ClusterRoleBinding \"cert-manager-controller-challenges\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.122333846Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for ClusterRoleBinding \"cert-manager-controller-ingress-shim\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.196538491Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for Role \"cert-manager-cainjector:leaderelection\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.206966784Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for Role \"cert-manager:leaderelection\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.299672802Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for Role \"cert-manager-webhook:dynamic-serving\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.308841075Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for RoleBinding \"cert-manager-cainjector:leaderelection\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.31679666Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for Service \"cert-manager-webhook\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.402407377Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for Deployment \"cert-manager-cainjector\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.491151726Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for Deployment \"cert-manager\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.50364734Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"Looks like there are no changes for Deployment \"cert-manager-webhook\"","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:55.591552541Z","version":"v3"} {"caller":"helm.go:69","component":"helm","info":"updating status for upgraded release for cert-manager","release":"cert-manager","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:56.89848182Z","version":"v3"} {"caller":"release.go:364","component":"release","helmVersion":"v3","info":"upgrade succeeded","phase":"upgrade","release":"cert-manager","resource":"ingress-nginx:helmrelease/cert-manager","revision":"v0.15.0","targetNamespace":"ingress-nginx","ts":"2020-10-08T13:49:58.000925052Z"}

Additional context

• Helm Operator version: 1.2.0
• Kubernetes version: v1.15.11

[ejimz]

found the fix in #457

I had to run: kubectl apply -f https://raw.githubusercontent.com/fluxcd/helm-operator/${VERSION}/deploy/crds.yaml