Skip to content

fix(a380x/fctl): Protection speeds improvements after flight model update #9694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Mar 19, 2025
Merged

fix(a380x/fctl): Protection speeds improvements after flight model update #9694

merged 24 commits into from
Mar 19, 2025

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Dec 31, 2024 •
edited
Loading

Fixes #9689
Fixes #8725
Fixes #9846

Summary of Changes

  • Adapted zero lift alpha to MSFS flight model values:
    image
  • Adapt alpha max and alpha prot values to match existing references
  • Fix high speed protection green double bar in PFD
  • Fix protection markers in PFD (and add simplified FCDC in the process)
  • Fix VMAX / VfeNext for CONF 1+F and CONF 1

Screenshots (if necessary)

image

vs
image

image
vs
image

image
vs
image

PFD direct law indications:
image

References

https://www.youtube.com/watch?v=hDh_9MEz-hg
https://www.youtube.com/watch?v=AI8yFhuEa4Q
https://www.youtube.com/watch?v=pHui34_ODnc
https://www.youtube.com/watch?v=qcXQKQukxkI&t=284s
https://www.youtube.com/watch?v=DtIF26FEZug&t=338s

Additional context

Note for reviewer: Only alpha max and alpha protection look-up tables were modified in the MATLAB models, no MATLAB review needed.

Current alpha tables:
alpha_max:
image

alpha_prot:
image

new alpha_0 table:
image

Discord username (if different from GitHub): floridude

Testing instructions

  1. Verify protection markers (pitch&roll, overspeed) show correctly in PFD in normal and in direct law (disable all PRIMs for that)
  2. Fly around, try to match PFD protection speeds to known references and report where they deviate
  3. Even without looking at references, the aircraft should perform reasonably, e.g. shouldn't activate protections at green dot speed in clean conf in standard turns.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@flogross89 flogross89 force-pushed the fix-a380x-fac-alpha-after-don branch from 2c3ace7 to 287cd2e Compare January 2, 2025 04:07
@flogross89 flogross89 force-pushed the fix-a380x-fac-alpha-after-don branch from 9062486 to 9583e06 Compare January 2, 2025 22:38
@flogross89 flogross89 changed the title fix(a380x/prim): Adapt alpha speeds after flight model update fix(a380x/fctl): Protection speeds improvements after flight model update Jan 2, 2025
@flogross89 flogross89 marked this pull request as ready for review January 2, 2025 22:41
@flogross89 flogross89 added QA A380 Only QA only for A380 required A380X Related to the A380X aircraft labels Jan 2, 2025
@flogross89 flogross89 added this to the v0.13.0 milestone Jan 3, 2025
@donstim donstim mentioned this pull request Jan 7, 2025
Closed
@flogross89 flogross89 mentioned this pull request Jan 16, 2025
Merged
lukecologne
lukecologne approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@lukecologne lukecologne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@flogross89
Merge branch 'master' into fix-a380x-fac-alpha-after-don
e2b0f64 
# Conflicts:
#	fbw-a380x/src/systems/instruments/src/PFD/FMA.tsx
@flogross89 flogross89 added the Waiting for PR merge Waiting for PR to be merged to fix the issue. label Feb 9, 2025
@flogross89 flogross89 mentioned this pull request Feb 11, 2025
Closed
@flogross89 flogross89 removed the Waiting for PR merge Waiting for PR to be merged to fix the issue. label Mar 17, 2025
@Jonny23787
Copy link
Contributor

Quality Assurance Trainee Report

Discord Username : jonny_23
Object of testing : #9694
Aircraft : A380X
Tier of Testing : 1
Date : 19/03/2025

Testing Process:

  1. Verified protection markers were shown correctly on PFD in both normal and direct law.
  2. Performed a test flight with multiple turns, checked that protections did not activate.
  3. Performed multiple landings at various weights and confirmed VLS, alpha prot and alpha max values were within margin of error compared to references with the similar weather conditions and weights.
  4. Performed a full flight with aircraft loaded to a realistic A380 LAW and confirmed protections were at appropriate speeds.

Testing Results:
Passed

@flogross89 flogross89 enabled auto-merge (squash) March 19, 2025 21:43
@flogross89 flogross89 merged commit 7af00a7 into flybywiresim:master Mar 19, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from 🟣 QA Review: Ready to Test to ✔️ Done in Quality Assurance Mar 19, 2025
Benjozork pushed a commit to Benjozork/a32nx that referenced this pull request Apr 12, 2025
@flogross89 @Benjozork
fix(a380x/fctl): Protection speeds improvements after flight model up…
e12f0b6 
…date (flybywiresim#9694)

* changelog

* rename FAC

* change PFD HSP bar threshold

* PRIM: New alpha prot/max LUTs

* implement simple FCDC

* fix FCDC build

* fix VfeN and vMax in A380OperatingSpeeds

* add direct law PFD indications

* changelog

* revert clean conf Vmo changes

* use Cpp shorthand

* delete unused function again after merge

* update FAC analog inputs SimConnect structure

* new alpha LUT after flight model update by don
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukecologne lukecologne lukecologne approved these changes

Assignees
No one assigned
Labels
A380X Related to the A380X aircraft QA A380 Only QA only for A380 required QA Passed
Projects
Quality Assurance
Status: ✔️ Done
Milestone
v0.13.0
3 participants
@flogross89 @Jonny23787 @lukecologne