fix(a32nx/fms): fix preselected cruise speed/mach value showing in the descent phase #9860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukecologne
reviewed
Feb 14, 2025
| @@ -1321,7 +1309,7 @@ export abstract class FMCMainDisplay implements FmsDataInterface, FmsDisplayInte | |||
| } | |||
| } | |||
|
|
|||
| private updatePreSelSpeedMach(preSel) { | |||
| private updatePreSelSpeedMach(preSel: number | undefined) { | |||
| // The timeout is required to create a delay for the current value to be read and the new one to be set | |||
There was a problem hiding this comment.
I don't really understand why this delay is there, is this still necessary or could it be removed?
There was a problem hiding this comment.
I haven't tested it without the delay. The idea is that when a new flight phase activates, we need to give the AP code time to set the preselected speed before we unset/re-set it. From the FMS, we have no control over when the FG activates the preselected speed after we fire the K:A32NX.FMS_PRESET_SPD_ACTIVATE event.
tracernz
approved these changes
Feb 14, 2025
fbw-a32nx/src/systems/instruments/src/MCDU/legacy/A32NX_FMCMainDisplay.ts
Outdated
Show resolved
Hide resolved
BlueberryKing
force-pushed
the
fix-spd-mach-presel
branch
2 times, most recently
from
c5f72e7 to
3462cc0
Compare
BlueberryKing
force-pushed
the
fix-spd-mach-presel
branch
from
3462cc0 to
9232778
Compare
BlueberryKing
force-pushed
the
fix-spd-mach-presel
branch
from
9232778 to
928cdbd
Compare
|
Quality Assurance Trainee Report Discord Username : jonny_23 Testing Process:
Testing Results: |
BlueberryKing
force-pushed
the
fix-spd-mach-presel
branch
from
928cdbd to
0f504cb
Compare
github-project-automation
bot
moved this from 🟣 QA Review: Ready to Test
to ✔️ Done
in Quality Assurance
Benjozork
pushed a commit
to Benjozork/a32nx
that referenced
this pull request
Apr 12, 2025
…e descent phase (flybywiresim#9860) * Fix cruise speed preselect showing up in descent * Document local variable * Update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9854
Summary of Changes
Fixes an issue where the preselected cruise speed/mach value was shown during the descent phase. This happened because the value was not properly reset.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
Go through the steps to reproduce the linked issue. Ensure the issue no longer occurs.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.