Skip to content

fix(fmgc): no lateral mode reversion to hdg when flying through discontinuity #9922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

fix(fmgc): no lateral mode reversion to hdg when flying through discontinuity #9922

wants to merge 5 commits into from

Conversation

juliansebline
Copy link
Contributor

@juliansebline juliansebline commented Mar 15, 2025 •
edited
Loading

Fixes #9895

Summary of Changes

Updated the SetSimVarValue with the correct event

Screenshots (if necessary)

{E86D8CE5-B3D4-4C17-B72A-21A366CB68A7}

References

Additional context

Testing instructions

  1. Load a flight to LXGB runway 27
  2. Load the departure
  3. Take off and wait

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@github-project-automation github-project-automation bot moved this to 🟡 Code Review: Ready for Review in Quality Assurance Mar 15, 2025
lukecologne
lukecologne reviewed Mar 15, 2025
View reviewed changes
Copy link
Member

@lukecologne lukecologne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right way to do it, a discontinuity is exactly not a normal pull action, but a reversion. It is an anti-pattern to trigger the triple click here instead of having the FG do it due to loss of NAV mode/reversion. #9898 should fix this in the proper way I think, but @BlueberryKing can probably confirm if it is implemented there or only in #9761

@BlueberryKing
Copy link
Member

This is not the right way to do it, a discontinuity is exactly not a normal pull action, but a reversion. It is an anti-pattern to trigger the triple click here instead of having the FG do it due to loss of NAV mode/reversion. #9898 should fix this in the proper way I think, but @BlueberryKing can probably confirm if it is implemented there or only in #9761

Yes, this is implemented in #9898. Sorry if you spent time looking into this, @juliansebline!

@tracernz tracernz added this to the v0.14.0 milestone Mar 30, 2025
@github-project-automation github-project-automation bot moved this from 🟡 Code Review: Ready for Review to ❌ Cancelled/Unfinished in Quality Assurance Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukecologne lukecologne lukecologne left review comments

Assignees
No one assigned
Labels
None yet
Projects
Quality Assurance
Status: ❌ Cancelled/Unfinished
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.

No lateral mode reversion to HDG when flying through discontinuity
4 participants
@juliansebline @BlueberryKing @lukecologne @tracernz