Remove legacy environment variables

Author: Sovietaced

flyteplugins/go/tasks/pluginmachinery/flytek8s/k8s_resource_adds.go

@@ -99,24 +99,6 @@ func GetExecutionEnvVars(id pluginsCore.TaskExecutionID, consoleURL string) []v1
 			v1.EnvVar{
 				Name:  "FLYTE_INTERNAL_TASK_VERSION",
 				Value: taskID.GetVersion(),
-			},
-			// Historic Task Definition Level env variables.
-			// Remove these once SDK is migrated to use the new ones.
-			v1.EnvVar{
-				Name:  "FLYTE_INTERNAL_PROJECT",
-				Value: taskID.GetProject(),
-			},
-			v1.EnvVar{
-				Name:  "FLYTE_INTERNAL_DOMAIN",
-				Value: taskID.GetDomain(),
-			},
-			v1.EnvVar{
-				Name:  "FLYTE_INTERNAL_NAME",
-				Value: taskID.GetName(),
-			},
-			v1.EnvVar{
-				Name:  "FLYTE_INTERNAL_VERSION",
-				Value: taskID.GetVersion(),
 			})
 
 	}

flyteplugins/go/tasks/pluginmachinery/flytek8s/k8s_resource_adds_test.go

@@ -28,13 +28,13 @@ func TestGetExecutionEnvVars(t *testing.T) {
 	}{
 		{
 			"no-console-url",
-			12,
+			8,
 			"",
 			nil,
 		},
 		{
 			"with-console-url",
-			13,
+			9,
 			"scheme://host/path",
 			&v12.EnvVar{
 				Name:  "FLYTE_EXECUTION_URL",
@@ -43,7 +43,7 @@ func TestGetExecutionEnvVars(t *testing.T) {
 		},
 		{
 			"with-console-url-ending-in-single-slash",
-			13,
+			9,
 			"scheme://host/path/",
 			&v12.EnvVar{
 				Name:  "FLYTE_EXECUTION_URL",
@@ -52,7 +52,7 @@ func TestGetExecutionEnvVars(t *testing.T) {
 		},
 		{
 			"with-console-url-ending-in-multiple-slashes",
-			13,
+			9,
 			"scheme://host/path////",
 			&v12.EnvVar{
 				Name:  "FLYTE_EXECUTION_URL",