Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ListNamedEntity breaks when passing a filter with sortKey of created_at #2327

Open
2 tasks done
pmahindrakar-oss opened this issue Apr 7, 2022 · 3 comments · May be fixed by flyteorg/flyteadmin#394
Open
2 tasks done

[BUG] ListNamedEntity breaks when passing a filter with sortKey of created_at #2327

pmahindrakar-oss opened this issue Apr 7, 2022 · 3 comments · May be fixed by flyteorg/flyteadmin#394
Assignees
@pmahindrakar-oss
Labels
bug Something isn't working flyteadmin Issue for FlyteAdmin Service stale

Comments

@pmahindrakar-oss
Copy link
Contributor

Describe the bug

By default flytectl uses created_at as sort key when listing flyte entities

When making ListNamedEntities with workflow resource type , the current api breaks with the following error

 flytectl get workflow -p flytesnacks -d development                                  
Error: rpc error: code = Unknown desc = failed database operation with column "workflows.created_at" must appear in the GROUP BY clause or be used in an aggregate function

Similarly it breaks on passing a field selector too

flytectl get workflow -p flytesnacks -d development --filter.fieldSelector "state=0"
Error: rpc error: code = Unknown desc = failed database operation with column "workflows.created_at" must appear in the GROUP BY clause or be used in an aggregate function

It returns correctly in case of project, domain, name

 flytectl get workflow -p flytesnacks -d development --filter.fieldSelector "state=0" --filter.sortBy "project"
 --------------- ------------- ------------------------------------------------------------- ------------- ------- 
| PROJECT (45)  | DOMAIN      | NAME                                                        | DESCRIPTION | STATE |
 --------------- ------------- ------------------------------------------------------------- ------------- ------- 
| flytesnacks   | development | core.containerization.use_secrets.my_secret_workflow        |             |       |
 --------------- ------------- ------------------------------------------------------------- ------------- ------- 
| flytesnacks   | development | core.control_flow.chain_tasks.chain_tasks_wf                |             |       |
 --------------- ------------- ------------------------------------------------------------- ------------- -------

Expected behavior

Named Entities should be able to sorted by created_at

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@pmahindrakar-oss pmahindrakar-oss added bug Something isn't working flyteadmin Issue for FlyteAdmin Service labels Apr 7, 2022
@pmahindrakar-oss pmahindrakar-oss added this to the 1.0.1 milestone Apr 7, 2022
@pmahindrakar-oss pmahindrakar-oss self-assigned this Apr 7, 2022
This was referenced Apr 7, 2022
Open
Merged
@EngHabu EngHabu removed this from the 1.0.1 milestone May 4, 2022
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 29, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 3, 2023
@github-actions GitHub Actions
Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmahindrakar-oss pmahindrakar-oss

Labels
bug Something isn't working flyteadmin Issue for FlyteAdmin Service stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sorting bug for named entities flyteorg/flyteadmin
3 participants
@EngHabu @eapolinario @pmahindrakar-oss