Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some output gone after refactoring? #13

Open
jvoigtlaender opened this issue Jun 21, 2024 · 2 comments · Fixed by #15
Open

Some output gone after refactoring? #13

jvoigtlaender opened this issue Jun 21, 2024 · 2 comments · Fixed by #15
Assignees

Comments

@jvoigtlaender
Copy link
Member

What happened to this messagebox output? It seems gone after the refactoring.

Originally posted by @jvoigtlaender in #12 (comment)

@jvoigtlaender
Copy link
Member Author

Also another place further down in the file.

This was referenced Jul 2, 2024
@jvoigtlaender
Copy link
Member Author

I don‘t buy the claim from #15 (comment) that this is fixed.

mentioned output was moved to the combined else block, starting in state_manager.py line 304

Two reasons:

  1. The messages code that was deleted was giving two different messages, so how can they both be captured by another single code block that has no variability?
  2. That other code block is at a different nesting level if if-elses. In fact, statically from the source code it seems obvious that under conditions that would reach the two deleted code blocks, the code block at line 304 will definitely not be reached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants