-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] documentation additions and broken link #1357
Comments
Thanks for reporting this @Walshkev! are you happy to do a PR and fix the issue? |
I am not sure I understand which one this is, can you point me to it? |
Yes, I am more than happy to do a pull request for these issues is the links I added for the contribution guide and the code of conduct acceptable for you.
…________________________________
From: Riccardo ***@***.***>
Sent: Wednesday, May 29, 2024 11:47 AM
To: foambubble/foam ***@***.***>
Cc: Walsh, Kevin Collier ***@***.***>; Mention ***@***.***>
Subject: Re: [foambubble/foam] [doc] documentation additions and broken link (Issue #1357)
[This email originated from outside of OSU. Use caution with links and attachments.]
Thanks for reporting this @Walshkev<https://github.com/Walshkev>! are you happy to do a PR and fix the issue?
—
Reply to this email directly, view it on GitHub<#1357 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ASMM4C2FAIB3WMT2RA7ROKLZEYPFZAVCNFSM6AAAAABIIEZDYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZYGA2TEOBTHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
i finished the this issue the pull request is [doc] documentation additions #1358 |
Great, thanks! I have merged it |
i found the broken link on the discord channel https://discord.com/channels/729975036148056075/729976283613626408 |
Thanks for that, I will fix it |
I noticed that the readme of this project does not contain the contribution guide or community guidelines. I have found the contribution guide deeper with in the repository. I have also found the original code of conduct https://foambubble.github.io/foam/dev/code-of-conduct and the contribution guide https://foambubble.github.io/foam/dev/contribution-guide.html for foam bubble which can be easily linked within the read me. Also, the link on the discord page for the community guidelines is currently broken.
The text was updated successfully, but these errors were encountered: