-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foam Web Extension #1395
Foam Web Extension #1395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not strictly about this PR - should have not been here 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not strictly about this PR - should have not been here 😅
Looks good to me! |
Great @pderaaij ! Again, I want to empathise that you basically did all the hard work here, I just repackaged it to avoid those extra dependencies 🙏 |
This PR is heavily inspired and influenced by #1290 - thanks @pderaaij for spearheading and working through this complex feature.
See that PR for more context.
Compared to #1290 , this PR:
This way:
The only thing I would have liked to add was running a basic test in the web extension (without the need for
mocha
) that would only test if the extension is present. Then again, this can be added as a second step.