Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Changing the names of program sections to follow kernel/libbpf.c convension - question about ability to contribute #335

Open
bartsmykla opened this issue Jun 15, 2022 · 1 comment

Comments

@bartsmykla
Copy link

Hi everyone! :-)

Because of requirements where our ebpf userspace loader needs to be written in go, for the last few days I was working on mariaging redbpf with cilium/ebpf library. I basically succeeded with some changes which I would like to upstream to cilium/ebpf, but there is one thing which I found would be great if I'll be able to upstream to redbpf.

Namely: cilium/ebpf is following kernel's libbpf.c convention in naming program sections (ref) and when I was playing working with redbpf and sockops I realized it uses different names for streamparser and streamverdict sections than the cilium/ebpf/kernel/libbpf.c (sk_skb/stream_parser and sk_skb/stream_verdict).

I believe it will be much harder to upstream the change in cilium/ebpf to support redbpf section names because of the convention they used, so I would like to ask, what is your opinion for me creating a PR which would change the names of sections in this library to follow the same convention as cilium/ebpf/kernel/libbpf.c? I believe it may be helpful for everyone in the future, who would like to use redbpf for kernel's part of ebpf and cilium/ebpf for the userspace's one.

@rsdy
Copy link
Collaborator

rsdy commented Jun 15, 2022

I'd welcome a patch like this, as it seems like a helpful addition. Since the next step forward is going to break some APIs anyway, I don't think this needs to be backwards compatible either. Please send a PR and cross-link this issue!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants