Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(elixir): Move to phoenix v1.3 architecture #103

Open
mrapacz opened this issue Sep 3, 2017 · 3 comments
Open

enhancement(elixir): Move to phoenix v1.3 architecture #103

mrapacz opened this issue Sep 3, 2017 · 3 comments

Comments

@mrapacz
Copy link
Collaborator

mrapacz commented Sep 3, 2017

Type

Enhancement

Current behaviour
Right now location of our models and logic is somewhat chaotic

Expected behaviour
We could move to architecture suggested by newest Phoenix, which is model-based. The directory hierarchy would probably look like:

room/
 - room.ex
 - ecto.ex/schema.ex (whatever), it can also be in room/room.ex, not sure yet how to solve this
 - other files
room.ex <- a module providing an API for other modules

This is how lib folder looks after generating example phoenix project and generating a user ecto model:
image

Motivation / use case
#52

@mrapacz
Copy link
Collaborator Author

mrapacz commented Sep 3, 2017

@pmrukot this change would require us to replace elm to lib/ too. What do you think about it?

@pmrukot
Copy link
Collaborator

pmrukot commented Sep 3, 2017

I would wait with this change, I would say it is not a priority for now, we have more important things to do. I would polish the product, deploy it, add missing features and then reorganise structure to match Phoenix 1.3 architecture. I do not want to bother myself with this change since I consider us having more important stuff to do.

Why do you consider having this a high priority?

@mrapacz
Copy link
Collaborator Author

mrapacz commented Sep 3, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants