Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialyxir): Add missing typespecs #120

Open
mrapacz opened this issue Oct 5, 2017 · 0 comments
Open

fix(dialyxir): Add missing typespecs #120

mrapacz opened this issue Oct 5, 2017 · 0 comments

Comments

@mrapacz
Copy link
Collaborator

mrapacz commented Oct 5, 2017

Type

Fix

Current behaviour

As for now we had to create the dialyxir.ignore_warnings file. We were getting so many because we did not define the UserSocket type (or we actually defined it as
@type t :: %Phoenix.Socket{}, which is not enough (we keep more data inside than the traditional socket). This is why all of the functions dealing with UserSocket are throwing errors.

Expected behaviour

No errors on output.

Motivation / use case

Dialyxir is right about throwing errors here because the type specs and the reality indeed are different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant