Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the three separate Toasties? #216

Open
mrapacz opened this issue Feb 28, 2018 · 0 comments
Open

Merge the three separate Toasties? #216

mrapacz opened this issue Feb 28, 2018 · 0 comments
Labels
Type: Question
Milestone
Elm refactor

Comments

@mrapacz
Copy link
Collaborator

mrapacz commented Feb 28, 2018

Type

Refactor

Current behaviour
As for now we have three separate Toasty messages, addToast functions and toastyConfigs. Perhaps we could merge them. But should we try to? On one hand, right now we are able to have different notifications in different subpages. Is that of a value to us or not? Perhaps we could leave the configs separated, but try to abstract the addToast function as it seems somewhat generic. What do you think?
@mrapacz mrapacz added this to the Elm refactor milestone Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Question
Projects
None yet
Milestone
Elm refactor
Development

No branches or pull requests
1 participant
@mrapacz