Skip to content

Commit f534463

Browse files
authored
Merge pull request #415 from bbirman/contributing
Add CONTRIBUTING.md
2 parents 442f131 + aacff28 commit f534463

File tree

1 file changed

+79
-0
lines changed

1 file changed

+79
-0
lines changed

CONTRIBUTING.md

Lines changed: 79 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
1+
# Contributing Guide For Salesforce Mobile SDK
2+
3+
This page lists the operational governance model of this project, as well as the recommendations and requirements for how to best contribute to Salesforce Mobile SDK. We strive to obey these as best as possible. As always, thanks for contributing – we hope these guidelines make it easier and shed some light on our approach and processes.
4+
5+
# Governance Model
6+
7+
## Salesforce Sponsored
8+
9+
The intent and goal of open sourcing this project is to increase the contributor and user base. However, only Salesforce employees will be given `admin` rights and will be the final arbitrars of what contributions are accepted or not.
10+
11+
# Issues, requests & ideas
12+
13+
Use GitHub Issues page to submit issues, enhancement requests and discuss ideas.
14+
15+
### Bug Reports and Fixes
16+
- If you find a bug, please search for it in the [Issues](https://github.com/forcedotcom/SalesforceMobileSDK-ReactNative/issues), and if it isn't already tracked,
17+
[create a new issue](https://github.com/forcedotcom/SalesforceMobileSDK-ReactNative/issues/new). Fill out the "Bug Report" section of the issue template. Even if an Issue is closed, feel free to comment and add details, it will still
18+
be reviewed.
19+
- Issues that have already been identified as a bug (note: able to reproduce) will be labelled `bug`.
20+
- If you'd like to submit a fix for a bug, [send a Pull Request](#creating_a_pull_request) and mention the Issue number.
21+
- Include tests that isolate the bug and verifies that it was fixed.
22+
23+
### New Features
24+
- If you'd like to add new functionality to this project, describe the problem you want to solve in a [new Issue](https://github.com/forcedotcom/SalesforceMobileSDK-ReactNative/issues/new).
25+
- Issues that have been identified as a feature request will be labelled `enhancement`.
26+
- If you'd like to implement the new feature, please wait for feedback from the project
27+
maintainers before spending too much time writing the code. In some cases, `enhancement`s may
28+
not align well with the project objectives at the time.
29+
30+
### Tests, Documentation, Miscellaneous
31+
- If you'd like to improve the tests, you want to make the documentation clearer, you have an
32+
alternative implementation of something that may have advantages over the way its currently
33+
done, or you have any other change, we would be happy to hear about it!
34+
- If its a trivial change, go ahead and [send a Pull Request](#creating_a_pull_request) with the changes you have in mind.
35+
- If not, [open an Issue](https://github.com/forcedotcom/SalesforceMobileSDK-ReactNative/issues/new) to discuss the idea first.
36+
37+
# Contribution Checklist
38+
39+
- [x] Clean, simple, well styled code
40+
- [x] Commits should be atomic and messages must be descriptive. Related issues should be mentioned by Issue number.
41+
- [x] Comments
42+
- Module-level & function-level comments.
43+
- Comments on complex blocks of code or algorithms (include references to sources).
44+
- [x] Tests
45+
- The test suite, if provided, must be complete and pass
46+
- Increase code coverage, not versa.
47+
- [x] Dependencies
48+
- Minimize number of dependencies.
49+
- Prefer Apache 2.0, BSD3, MIT, ISC and MPL licenses.
50+
- [x] Reviews
51+
- Changes must be approved via peer code review
52+
53+
# Creating a Pull Request
54+
55+
1. **Ensure the bug/feature was not already reported** by searching on GitHub under Issues. If none exists, create a new issue so that other contributors can keep track of what you are trying to add/fix and offer suggestions (or let you know if there is already an effort in progress).
56+
3. **Clone** the forked repo to your machine.
57+
4. **Create** a new branch to contain your work (e.g. `git br fix-issue-11`)
58+
4. **Commit** changes to your own branch.
59+
5. **Push** your work back up to your fork. (e.g. `git push fix-issue-11`)
60+
6. **Submit** a Pull Request against the `dev` branch and refer to the issue(s) you are fixing. Try not to pollute your pull request with unintended changes. Keep it simple and small.
61+
7. **Sign** the Salesforce CLA (you will be prompted to do so when submitting the Pull Request)
62+
63+
> **NOTE**: Be sure to [sync your fork](https://help.github.com/articles/syncing-a-fork/) before making a pull request.
64+
65+
# Contributor License Agreement ("CLA")
66+
In order to accept your pull request, we need you to submit a CLA. You only need
67+
to do this once to work on any of Salesforce's open source projects.
68+
69+
Complete your CLA here: <https://cla.salesforce.com/sign-cla>
70+
71+
# Issues
72+
We use GitHub issues to track public bugs. Please ensure your description is
73+
clear and has sufficient instructions to be able to reproduce the issue.
74+
75+
# Code of Conduct
76+
Please follow our [Code of Conduct](CODE_OF_CONDUCT.md).
77+
78+
# License
79+
By contributing your code, you agree to license your contribution under the terms of our project [LICENSE](LICENSE.txt) and to sign the [Salesforce CLA](https://cla.salesforce.com/sign-cla)

0 commit comments

Comments
 (0)