fix: remove eslint.nodePath

Author: madhur310

packages/lightning-lsp-common/core.code-workspace

@@ -26,7 +26,6 @@
             "**/target/**": true,
             "**/bin/**": true
         },
-        "eslint.nodePath": "/Users/bbuchanan/tools/eslint-tool/1.0.11/node_modules",
         "perforce.maxBuffer": 10485760,
         "perforce.editOnFileSave": true,
         "perforce.editOnFileModified": true,

packages/lightning-lsp-common/src/__tests__/context.test.ts

@@ -186,7 +186,6 @@ describe('WorkspaceContext', () => {
 
     const verifyCoreSettings = (settings: any): void => {
         expect(settings['files.watcherExclude']).toBeDefined();
-        expect(settings['eslint.nodePath']).toBeDefined();
         expect(settings['perforce.client']).toBe('username-localhost-blt');
         expect(settings['perforce.user']).toBe('username');
         expect(settings['perforce.port']).toBe('ssl:host:port');

packages/lightning-lsp-common/src/base-context.ts

@@ -6,7 +6,6 @@
  */
 
 import * as fs from 'fs';
-import { homedir } from 'os';
 import * as path from 'path';
 import { TextDocument } from 'vscode-languageserver';
 import ejs from 'ejs';
@@ -76,27 +75,6 @@ export const updateForceIgnoreFile = async (forceignorePath: string, addTsConfig
     await fs.promises.writeFile(forceignorePath, forceignoreContent.trim());
 };
 
-const getESLintToolVersion = async (): Promise<string> => {
-    const eslintToolDir = path.join(homedir(), 'tools', 'eslint-tool');
-    const packageJsonPath = path.join(eslintToolDir, 'package.json');
-    if (fs.existsSync(packageJsonPath)) {
-        const packageJson = JSON.parse(await fs.promises.readFile(packageJsonPath, 'utf8'));
-        return packageJson.version;
-    }
-    return '1.0.3';
-};
-
-const findCoreESLint = async (): Promise<string> => {
-    const eslintToolDir = path.join(homedir(), 'tools', 'eslint-tool');
-    if (!fs.existsSync(eslintToolDir)) {
-        console.warn('core eslint-tool not installed: ' + eslintToolDir);
-        // default
-        return '~/tools/eslint-tool/1.0.3/node_modules';
-    }
-    const eslintToolVersion = await getESLintToolVersion();
-    return path.join(eslintToolDir, eslintToolVersion, 'node_modules');
-};
-
 // exported for testing
 export const processTemplate = (template: string, data: any): string => ejs.render(template, data);
 
@@ -416,15 +394,11 @@ export abstract class BaseWorkspaceContext {
             folders: this.workspaceRoots.map((root) => ({ path: root })),
             settings: {},
         };
-        const eslintPath = await findCoreESLint();
-        await this.updateCoreCodeWorkspace(workspace.settings, eslintPath);
+        await this.updateCoreCodeWorkspace(workspace.settings);
         return workspace;
     }
 
     private async updateCoreSettings(settings: any): Promise<void> {
-        // Get eslint path once to avoid multiple warnings
-        const eslintPath = await findCoreESLint();
-
         try {
             // Load core settings template
             const coreSettingsTemplate = await fs.promises.readFile(utils.getCoreResource('settings-core.json'), 'utf8');
@@ -435,7 +409,6 @@ export abstract class BaseWorkspaceContext {
 
             // Update eslint settings
             settings['eslint.workingDirectories'] = this.workspaceRoots;
-            settings['eslint.nodePath'] = eslintPath;
             settings['eslint.validate'] = ['javascript', 'typescript'];
             settings['eslint.options'] = {
                 overrideConfigFile: path.join(this.workspaceRoots[0], '.eslintrc.json'),
@@ -449,17 +422,15 @@ export abstract class BaseWorkspaceContext {
             console.error('updateCoreSettings: Error loading core settings template:', error);
             // Fallback to basic settings
             settings['eslint.workingDirectories'] = this.workspaceRoots;
-            settings['eslint.nodePath'] = eslintPath;
             settings['eslint.validate'] = ['javascript', 'typescript'];
             settings['eslint.options'] = {
                 overrideConfigFile: path.join(this.workspaceRoots[0], '.eslintrc.json'),
             };
         }
     }
 
-    private async updateCoreCodeWorkspace(settings: any, eslintPath: string): Promise<void> {
+    private async updateCoreCodeWorkspace(settings: any): Promise<void> {
         settings['eslint.workingDirectories'] = this.workspaceRoots;
-        settings['eslint.nodePath'] = eslintPath;
         settings['eslint.validate'] = ['javascript', 'typescript'];
         settings['eslint.options'] = {
             overrideConfigFile: path.join(this.workspaceRoots[0], '.eslintrc.json'),

packages/lightning-lsp-common/src/resources/core/core.code-workspace.json

@@ -26,7 +26,6 @@
             "**/target/**": true,
             "**/bin/**": true
         },
-        "eslint.nodePath": "${eslint_node_path}",
         "perforce.maxBuffer": 10485760,
         "perforce.editOnFileSave": true,
         "perforce.editOnFileModified": true,

packages/lightning-lsp-common/src/resources/core/settings-core.json

@@ -20,7 +20,6 @@
         "**/target/**": true,
         "**/bin/**": true
     },
-    "eslint.nodePath": "${eslint_node_path}",
     "perforce.maxBuffer": 10485760,
     "perforce.editOnFileSave": true,
     "perforce.editOnFileModified": true,

packages/lwc-language-server/core.code-workspace

@@ -26,7 +26,6 @@
             "**/target/**": true,
             "**/bin/**": true
         },
-        "eslint.nodePath": "/Users/bbuchanan/tools/eslint-tool/1.0.11/node_modules",
         "perforce.maxBuffer": 10485760,
         "perforce.editOnFileSave": true,
         "perforce.editOnFileModified": true,

test-workspaces/core-like-workspace/app/main/core/ui-force-components/core.code-workspace

@@ -12,7 +12,6 @@
       "test-workspaces/core-like-workspace/app/main/core/ui-force-components",
       "test-workspaces/core-like-workspace/app/main/core/ui-global-components"
     ],
-    "eslint.nodePath": "~/tools/eslint-tool/1.0.3/node_modules",
     "eslint.validate": [
       "javascript",
       "typescript"

test-workspaces/sfdx-workspace/core.code-workspace

@@ -8,7 +8,6 @@
     "eslint.workingDirectories": [
       "/Users/madhur.shrivastava/lightning-language-server/test-workspaces/sfdx-workspace"
     ],
-    "eslint.nodePath": "~/tools/eslint-tool/1.0.3/node_modules",
     "eslint.validate": [
       "javascript",
       "typescript"