feat(apex-oas): defer activation until commands run - W-22168691#7351
Open
mshanemc wants to merge 24 commits into
Open
feat(apex-oas): defer activation until commands run - W-22168691#7351mshanemc wants to merge 24 commits into
mshanemc wants to merge 24 commits into
Conversation
OAS tests migrated to .headless.spec.ts format and use waitForEsrFile to poll fs.access for durable on-disk artifacts instead of flaky notification toasts. Update coding-playwright-tests.md to clarify desktop-only tests may use fs/path, and add guidance section on reliable async assertions. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
mshanemc
requested review from
daphne-sfdc and
diyer
and removed request for
diyer
E2E_FROM_VSIX=1 requires .vsix files; vscode:bundle only produces dist/.
…r-apex-oas-activation # Conflicts: # packages/playwright-vscode-ext/src/utils/helpers.ts
# Conflicts: # .vscode/cspell.json # packages/salesforcedx-vscode-apex-oas/src/apexExtensionUtils.ts # packages/salesforcedx-vscode-apex-oas/src/commands/createApexAction.ts # packages/salesforcedx-vscode-apex-oas/src/commands/index.ts # packages/salesforcedx-vscode-apex-oas/src/coreExtensionUtils.ts # packages/salesforcedx-vscode-apex-oas/src/oas/documentProcessorPipeline/betaInfoInjectionStep.ts # packages/salesforcedx-vscode-apex-oas/src/oas/documentProcessorPipeline/pipeline.ts # packages/salesforcedx-vscode-apex-oas/src/oas/externalServiceRegistrationManager.ts # packages/salesforcedx-vscode-apex-oas/src/oas/generationInteractionLogger.ts # packages/salesforcedx-vscode-apex-oas/src/oas/generationStrategy/openapi3.schema.ts # packages/salesforcedx-vscode-apex-oas/src/telemetry/index.ts # packages/salesforcedx-vscode-apex-oas/test/jest/index.test.ts # packages/salesforcedx-vscode-automation-tests/test/specs/createOasDoc.e2e.ts # packages/salesforcedx-vscode-automation-tests/test/testData/oasDocs.ts # packages/salesforcedx-vscode-automation-tests/test/utils/sampleClassData.ts
…r-apex-oas-activation # Conflicts: # packages/effect-ext-utils/src/utils.ts # packages/playwright-vscode-ext/src/utils/helpers.ts # packages/salesforcedx-utils-vscode/src/index.ts # packages/salesforcedx-vscode-core/src/commands/util/lwcAuraDuplicateComponentCheckers.ts
… W-22168691 The bundled salesforcedx-einstein-gpt (A4V) extension checks the EGPT-for-developers entitlement on default-org change by fetching a JWT. E2E scratch orgs lack that entitlement, so the check fails and the extension logs JWT errors. These are benign — OAS generation doesn't depend on EGPT — but validateNoCriticalErrors flagged them, failing the OAS desktop specs deterministically on macOS and ubuntu. Add three patterns to NON_CRITICAL_ERROR_PATTERNS to cover the JWT creation failure, the A4V activation-error wrapper, and the user-facing UnknownJwtError message (apostrophe-agnostic substring, since the log uses a curly apostrophe). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…r-apex-oas-activation # Conflicts: # packages/playwright-vscode-ext/src/utils/helpers.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
salesforcedx-vscode-apex-oasactivation until its commands run; no eager activation on project open. See contributing/decisions/activationEvents.md.salesforcedx-vscode-apex-replay-debugger-e2eMocha suite to Playwright.headless.spec.tsinsalesforcedx-vscode-apex-oas; addapexOasE2E.ymlworkflow.annotateRootSpan(neweffect-ext-utilshelper); replace ad-hoc generation interaction logger.What issues does this PR fix or reference?
@W-22168691@