Knip update + layout in root

AlemTuzlak · AlemTuzlak · commit 0a8dce43e32d · 2024-12-11T10:58:17.000+01:00
diff --git a/app/root.tsx b/app/root.tsx
@@ -7,7 +7,6 @@ import { LanguageSwitcher } from "./library/language-switcher"
 import tailwindcss from "./tailwind.css?url"
 
 export async function loader({ context }: Route.LoaderArgs) {
-	if (!context) throw new Error("No context")
 	const { lang, clientEnv } = context
 	return { lang, clientEnv }
 }
@@ -20,11 +19,21 @@ export const handle = {
 
 export default function App({ loaderData }: Route.ComponentProps) {
 	const { lang, clientEnv } = loaderData
-	const { i18n } = useTranslation()
 	useChangeLanguage(lang)
 
 	return (
-		<html className="overflow-y-auto overflow-x-hidden" lang={lang} dir={i18n.dir()}>
+		<>
+			<Outlet />
+			{/* biome-ignore lint/security/noDangerouslySetInnerHtml: We set the window.env variable to the client env */}
+			<script dangerouslySetInnerHTML={{ __html: `window.env = ${JSON.stringify(clientEnv)}` }} />
+		</>
+	)
+}
+
+export const Layout = ({ children }: { children: React.ReactNode }) => {
+	const { i18n } = useTranslation()
+	return (
+		<html className="overflow-y-auto overflow-x-hidden" lang={i18n.language} dir={i18n.dir()}>
 			<head>
 				<meta charSet="utf-8" />
 				<meta name="viewport" content="width=device-width, initial-scale=1" />
@@ -33,11 +42,9 @@ export default function App({ loaderData }: Route.ComponentProps) {
 			</head>
 			<body className="w-full h-full">
 				<LanguageSwitcher />
-				<Outlet />
+				{children}
 				<ScrollRestoration />
 				<Scripts />
-				{/* biome-ignore lint/security/noDangerouslySetInnerHtml: We set the window.env variable to the client env */}
-				<script dangerouslySetInnerHTML={{ __html: `window.env = ${JSON.stringify(clientEnv)}` }} />
 			</body>
 		</html>
 	)
diff --git a/knip.json b/knip.json
@@ -1,15 +1,8 @@
 {
 	"$schema": "https://unpkg.com/knip@5/schema.json",
-	"entry": [
-		"scripts/*.{ts,js}",
-		"app/routes.ts",
-		"vite.config.ts",
-		"vitest.workspace.ts",
-		"vitest.config.ts",
-		"app/server/*.ts"
-	],
+	"entry": ["scripts/*.{ts,js}", "app/routes.ts", "app/server/*.ts", "app/library/icon/Icon.tsx"],
 	"remix": true,
-	"lefthook": true,
-	"project": ["**/*.{js,cjs,mjs,jsx,ts,cts,mts,tsx}", "vite.config.ts", "vitest.workspace.ts", "vitest.config.ts"],
-	"ignore": ["app/library/icon/icons/types.ts", "**/*.server.test.{ts,tsx}", "**/*.browser.test.{ts,tsx}"]
+	"project": ["**/*.{js,cjs,mjs,jsx,ts,cts,mts,tsx}"],
+	"ignore": ["app/library/icon/icons/types.ts"],
+	"ignoreDependencies": ["@babel/preset-typescript", "babel-plugin-react-compiler"]
 }
diff --git a/package.json b/package.json
@@ -64,7 +64,7 @@
 		"babel-plugin-react-compiler": "19.0.0-beta-df7b47d-20241124",
 		"chalk": "5.3.0",
 		"happy-dom": "15.11.6",
-		"knip": "5.37.2",
+		"knip": "5.39.4",
 		"lefthook": "1.8.4",
 		"playwright": "1.49.0",
 		"postcss": "8.4.49",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
