submitData gets thrown away if onValid submit handler is used

[melanieseltzer]

Hi folks 👋

I am using the onValid submit handler in the following way (with a fetcher):

submitHandlers: {
  onValid: (data) => {
    const dirtyValues = getDirtyFormValues(data, dirtyFields);
    const formData = createFormData(dirtyValues);
    fetcher.submit(formData, {
      method: "POST",
    });
  },
},

I noticed that when I do this, it now no longer passes through extra values from submitData to the server on form submission 🤔

Looks like the merged payload gets thrown away when onValid is taking over.

Is that intentional? Could they just be merged into the data passed into the valid handler here? Or do I have to manually pass them myself in createFormData now in onValid (not use submitData anymore).

[AlemTuzlak]

Hello! It is indeed intentional as I'd expect either that you have a valid onValid that you get the original data then do something with it and submit it in a custom way, or you just want to pass along a few fields to the submit and you don't want to use a custom one. I'd expect the dirtyValues here to be passed alongside your custom data into the fetcher.submit

[melanieseltzer]

Thanks, that makes sense 👍 Just submitted a PR to add a small note about this in the readme docs, as maybe others could be surprised by this like I was.