Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate webpage build from data processing steps in action #262

Open
LukasWallrich opened this issue Mar 5, 2025 · 3 comments
Open

Separate webpage build from data processing steps in action #262

LukasWallrich opened this issue Mar 5, 2025 · 3 comments
Assignees

Comments

@LukasWallrich
Copy link
Contributor

We are now doing a lot of data processing in the build action

  • Tenzing
  • Curated Resources
  • Google Analytics
  • References (to come)

It is not necessary to do all of that every time we test a PR commit - and one of these actions breaking should not prevent the webpage from getting deployed (as Tenzing did in the past two days).

@richarddushime could you maybe help to split the action into one that processes data (and is called daily or on request) - and a build action that uses the artefact from the data processing action to rebuild the website (daily - after the data processing - and after each PR/commit)?

@richarddushime richarddushime self-assigned this Mar 6, 2025
@richarddushime
Copy link
Contributor

I will fix this ASAP
Thanks

@LukasWallrich
Copy link
Contributor Author

Great progress on this!

Two small things:

  • can we avoid code duplication? Currently, the code is repeated in the build action and the data processing action, which is likely to lead to bugs over time
  • can we pull the forrt cv (in static/files) from this repo: https://github.com/forrtproject/cv

@LukasWallrich
Copy link
Contributor Author

@richarddushime thanks for making it more robust - but Google Scholar now continuously fails, so we need to fix that. Also, can we make failures more visible - e.g., generating issues/issue comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants