Skip to content

Commit 1362750

Browse files
iamareebjamaliamareebjamal
authored
chore: Release v1.7.0 (#2734)
chore: Release v1.7.0
2 parents 309bc4c + 5961151 commit 1362750

File tree

158 files changed

+2837
-2178
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

158 files changed

+2837
-2178
lines changed

‎.github/ISSUE_TEMPLATE

-23
This file was deleted.

‎.github/ISSUE_TEMPLATE/bug_report.md

+40
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
---
2+
name: Bug report
3+
about: Create a bug report to help us improve
4+
5+
---
6+
7+
**Describe the bug**
8+
<!-- A clear and concise description of what the bug is. -->
9+
10+
**To Reproduce**
11+
<!--Steps to reproduce the behavior:
12+
1. Go to '...'
13+
2. Click on '....'
14+
3. Scroll down to '....'
15+
4. See error -->
16+
17+
**Expected behavior**
18+
<!-- A clear and concise description of what you expected to happen. -->
19+
20+
**Logs**
21+
<!-- Please add logs in case of any crash or applicable error. -->
22+
23+
**Screenshots**
24+
<!-- If applicable, add screenshots to help explain your problem. -->
25+
26+
**Smartphone Info:**
27+
<!-- Please complete the following information -->
28+
| | |
29+
|---------------|-|
30+
|Device |<!-- [e.g. Moto G5 Plus] -->|
31+
|Android Version|<!-- [e.g. Oreo 8.1] --> |
32+
33+
**Additional context**
34+
<!-- Add any other context about the problem here. -->
35+
36+
**Would you like to work on the issue?**
37+
<!-- Please let us know if you can work on it or the issue should be assigned to someone else. -->
38+
- [ ] Yes
39+
- [ ] No
40+
- Other:

‎.github/ISSUE_TEMPLATE/chore.md

+14
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
---
2+
name: Chore
3+
about: Issues related to docs, workflow, dependency and others
4+
5+
---
6+
7+
**Describe the chore**
8+
<!-- A clear and concise description of what you want to do. -->
9+
10+
**Would you like to work on the issue?**
11+
<!-- Please let us know if you can work on it or the issue should be assigned to someone else. -->
12+
- [ ] Yes
13+
- [ ] No
14+
- Other:

‎.github/ISSUE_TEMPLATE/feature_request.md

+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
---
2+
name: Feature request
3+
about: Suggest a feature for this project
4+
5+
---
6+
7+
**Describe the feature you'd like**
8+
<!-- A clear and concise description of what you want to happen. -->
9+
10+
**Screenshots**
11+
<!-- Add screenshots to provide context or UI mockup. -->
12+
13+
**Additional context**
14+
<!-- Add any other context about the problem here. -->
15+
16+
**Would you like to work on the issue?**
17+
<!-- Please let us know if you can work on it or the issue should be assigned to someone else. -->
18+
- [ ] Yes
19+
- [ ] No
20+
- Other:

‎README.md

+23-11
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ Do you have many different apps on your Android Phone for the purpose of clickin
4848

4949
* Finally, after all this editing you can easily share the image to your favourite social media sites with our easy-to-use sharing feature.
5050

51-
* Facebook, Twitter, NextCloud, OwnCloud, Imgur, Dropbox, Box, Flickr, Pinterest, Instagram, Whatsapp, and Tumblr - You name it and we have it covered.
51+
* Facebook, Messenger, Twitter, NextCloud, OwnCloud, Imgur, Dropbox, Box, Flickr, Pinterest, Instagram, Whatsapp, and Tumblr - You name it and we have it covered.
5252

5353
## How to Contribute
5454
This is an Open Source project and we would be happy to see contributors who report bugs and file feature requests by submitting pull requests as well.This project adheres to the [Contributor Covenant](https://github.com/fossasia/phimpme-android/blob/development/CONTRIBUTING.md). By participating, you are expected to uphold this code style. Please report issues here https://github.com/fossasia/phimpme-android/issues
@@ -109,19 +109,19 @@ Before you begin, you should have already downloaded the Android Studio SDK and
109109
- Copy all the files from *"OpenCV-android-sdk/sdk/native/libs"* to *"phimpme-android/app/src/main/jniLibs"* (create directory if it doesn't exist)
110110
- Now build your project. If your build fails then try deleting these build directories *"phimpme-android/app/.externalNativeBuild"* and *"phimpme-android/app/build"*, if they exist and run the build again.
111111

112-
7. Once all build errors have been resolved, you should be all set to build the app and test it.
112+
7. If build error still persist, try replacing ndk with ndk version 16b from [ndk-archives](https://developer.android.com/ndk/downloads/older_releases) . Once all build errors have been resolved, you should be all set to build the app and test it.
113113

114114
8. To Build the app, go to *Build > Make Project* (or alternatively press the Make Project icon in the toolbar).
115115

116116
9. If the app was built successfully, you can test it by running it on either a real device or an emulated one by going to *Run > Run 'app'* or pressing the Run icon in the toolbar.
117117

118118
10. **To enable the sharing features to a different account, add API_KEY/ APP_ID associated with accounts**. Add the Keys in `constant.java` and `strings.xml`. Following are the links to developer pages of account. Go there to create apps and get keys.
119-
* Facebook: https://developers.facebook.com
119+
* Nextcloud: https://docs.nextcloud.com/server/stable/developer_manual/
120120
* Twitter: https://dev.twitter.com
121121
* Flickr: https://www.flickr.com/services/developer
122122
* Pinterest: https://developers.pinterest.com
123-
* Tumblr: https://www.tumblr.com/developers
124-
* Imgur: https://api.imgur.com
123+
* Owncloud: https://doc.owncloud.org/server/10.0/developer_manual/
124+
* Imgur: https://apidocs.imgur.com/
125125
* Box: https://developer.box.com
126126
* Dropbox: https://www.dropbox.com/developers
127127

@@ -138,7 +138,9 @@ The project is maintained by
138138
<table border="0">
139139
<tr>
140140
<td width="240">
141+
<p align="center">
141142
<img src="https://avatars2.githubusercontent.com/u/20367966?v=4&s=150" />
143+
</p>
142144
<div align="center">
143145
Anant Prasad
144146
</div>
@@ -150,8 +152,10 @@ The project is maintained by
150152
</td>
151153

152154
<td width="240">
155+
<p align="center">
153156
<img src="https://avatars0.githubusercontent.com/u/9361754?v=4&s=150"/>
154-
<div align="center">
157+
</p>
158+
<div align="center">
155159
Mohit Manuja
156160
</div>
157161
<p align="center">
@@ -162,7 +166,9 @@ The project is maintained by
162166
</td>
163167

164168
<td width="240">
169+
<p align="center">
165170
<img src="https://avatars1.githubusercontent.com/u/6936968?v=4&s=150" />
171+
</p>
166172
<div align="center">
167173
Pawan Pal
168174
</div>
@@ -174,7 +180,9 @@ The project is maintained by
174180
</td>
175181

176182
<td width="240">
177-
<img src="https://avatars0.githubusercontent.com/u/17337006?v=4&s=150"/>
183+
<p align="center">
184+
<img src="https://avatars0.githubusercontent.com/u/17337006?v=4&s=150" />
185+
</p>
178186
<div align="center">
179187
Subhankar Shah
180188
</div>
@@ -189,8 +197,10 @@ The project is maintained by
189197

190198
<tr>
191199
<td width="240">
192-
<img src="https://avatars2.githubusercontent.com/u/15368561?v=4&s=150"/>
193-
<div align="center">
200+
<p align="center">
201+
<img src="https://avatars2.githubusercontent.com/u/15368561?v=4&s=150" />
202+
</p>
203+
<div align="center">
194204
Vinay Sajjanapu
195205
</div>
196206
<p align="center">
@@ -201,8 +211,10 @@ The project is maintained by
201211
</td>
202212

203213
<td width="240">
204-
<img src="https://avatars1.githubusercontent.com/u/20841578?s=150&u=ccf2c85bac58c92f69c4c69ce2c46dcee4564e23&v=4"/>
205-
<div align="center">
214+
<p align="center">
215+
<img src="https://avatars1.githubusercontent.com/u/20841578?s=150&u=ccf2c85bac58c92f69c4c69ce2c46dcee4564e23&v=4" />
216+
</p>
217+
<div align="center">
206218
Saurav Vishal
207219
</div>
208220

‎app/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ dependencies {
111111
compile 'com.google.android.exoplayer:exoplayer:r1.5.7'
112112

113113
//utils
114-
compile 'com.github.deano2390:MaterialShowcaseView:1.1.0'
114+
compile 'com.github.deano2390:MaterialShowcaseView:1.2.0@aar'
115115
compile "com.jakewharton:butterknife:$rootProject.butterknifeVersion"
116116
annotationProcessor "com.jakewharton:butterknife-compiler:$rootProject.butterknifeVersion"
117117
compile 'com.github.bumptech.glide:glide:3.7.0'

‎app/src/main/AndroidManifest.xml

+30-8
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,35 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
33
xmlns:tools="http://schemas.android.com/tools"
4-
package="org.fossasia.phimpme"
5-
android:versionCode="8"
6-
android:versionName="1.6.0">
4+
package="org.fossasia.phimpme"
5+
android:versionCode="9"
6+
android:versionName="1.7.0">
77

88
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
9+
910
<uses-permission android:name="android.permission.READ_SMS"
1011
tools:node="remove"/>
1112
<uses-permission android:name="android.permission.RECEIVE_SMS"
1213
tools:node="remove"/>
14+
<uses-permission android:name="android.permission.SEND_SMS"
15+
tools:node="remove"/>
16+
<uses-permission android:name="android.permission.WRITE_SMS"
17+
tools:node="remove"/>
18+
<uses-permission android:name="android.permission.CALL_PHONE"
19+
tools:node="remove"/>
20+
<uses-permission android:name="android.permission.WRITE_CALL_LOG"
21+
tools:node="remove"/>
22+
<uses-permission android:name="android.permission.READ_CALL_LOG"
23+
tools:node="remove"/>
24+
<uses-permission android:name="android.permission.PROCESS_OUTGOING_CALLS"
25+
tools:node="remove"/>
26+
<uses-permission android:name="android.permission.MANAGE_OWN_CALLS"
27+
tools:node="remove"/>
28+
<uses-permission android:name="android.permission.ANSWER_PHONE_CALLS"
29+
tools:node="remove"/>
30+
<uses-permission android:name="android.permission.READ_PHONE_NUMBERS"
31+
tools:node="remove"/>
32+
1333
<uses-permission android:name="android.permission.CAMERA" />
1434
<uses-permission android:name="android.permission.RECORD_AUDIO" />
1535
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
@@ -45,8 +65,8 @@
4565

4666
<activity
4767
android:name=".opencamera.Camera.CameraActivity"
48-
android:screenOrientation="portrait"
4968
android:parentActivityName=".gallery.activities.LFMainActivity"
69+
android:screenOrientation="portrait"
5070
android:theme="@style/Theme.AppCompat.NoActionBar">
5171
<intent-filter>
5272
<action android:name="android.media.action.IMAGE_CAPTURE_SECURE" />
@@ -193,6 +213,7 @@
193213
android:name=".gallery.activities.SingleMediaActivity"
194214
android:configChanges="orientation|screenSize|uiMode|touchscreen|screenLayout"
195215
android:label="@string/app_name"
216+
android:windowSoftInputMode="adjustPan"
196217
android:parentActivityName=".gallery.activities.LFMainActivity"
197218
android:theme="@style/Theme.AppCompat.NoActionBar">
198219
<intent-filter>
@@ -210,7 +231,7 @@
210231

211232
<category android:name="android.intent.category.DEFAULT" />
212233
</intent-filter>
213-
<intent-filter>
234+
<intent-filter tools:ignore="AppLinkUrlError">
214235
<action android:name="android.intent.action.VIEW" />
215236

216237
<category android:name="android.intent.category.DEFAULT" />
@@ -236,6 +257,7 @@
236257
<activity
237258
android:name=".gallery.activities.SettingsActivity"
238259
android:configChanges="orientation|screenSize"
260+
android:windowSoftInputMode="adjustNothing"
239261
android:label="@string/settings"
240262
android:theme="@style/Theme.AppCompat.NoActionBar">
241263
<intent-filter>
@@ -284,9 +306,10 @@
284306
<activity
285307
android:name=".editor.EditImageActivity"
286308
android:theme="@style/AppTheme.NoActionBar"
309+
287310
android:windowSoftInputMode="adjustPan"
288-
android:configChanges="orientation|screenSize"
289311
/>
312+
290313
<activity
291314
android:name="com.yalantis.ucrop.UCropActivity"
292315
android:screenOrientation="portrait"
@@ -371,8 +394,7 @@
371394
android:value="78c6ec5c18fcd10ffbfd28ae038f3311f2763889" />
372395

373396
<activity android:name=".editor.CompressImageActivity"></activity>
374-
<activity android:name=".trashbin.TrashBinActivity">
375-
</activity>
397+
<activity android:name=".trashbin.TrashBinActivity"></activity>
376398
</application>
377399

378400
</manifest>

‎app/src/main/java/org/fossasia/phimpme/MyApplication.java

-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ public class MyApplication extends Application {
2929

3030
private HandlingAlbums albums = null;
3131
public static Context applicationContext;
32-
public ImageLoader imageLoader;
33-
private Boolean isPublished = false; // Set this to true at the time of release
3432
private RefWatcher refWatcher;
3533
public Album getAlbum() {
3634
return albums.dispAlbums.size() > 0 ? albums.getCurrentAlbum() : Album.getEmptyAlbum();

‎app/src/main/java/org/fossasia/phimpme/accounts/AccountActivity.java

+2-13
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
import android.content.Context;
44
import android.content.DialogInterface;
55
import android.content.Intent;
6-
import android.net.ConnectivityManager;
7-
import android.net.NetworkInfo;
86
import android.os.Bundle;
97
import android.support.design.widget.BottomNavigationView;
108
import android.support.design.widget.CoordinatorLayout;
@@ -84,7 +82,6 @@ public class AccountActivity extends ThemedActivity implements AccountContract.V
8482
private static final int NEXTCLOUD_REQUEST_CODE = 3;
8583
private static final int OWNCLOUD_REQUEST_CODE = 9;
8684
private static final int RESULT_OK = 1;
87-
private static final int RC_SIGN_IN = 9001;
8885
public static final String BROWSABLE = "android.intent.category.BROWSABLE";
8986
public final static String CLOUDRAIL_APP_KEY = Constants.CLOUDRAIL_LICENSE_KEY;//CloudRail_App-Key
9087
@BindView(R.id.accounts_parent)
@@ -109,7 +106,6 @@ public class AccountActivity extends ThemedActivity implements AccountContract.V
109106
private CloudRailServices cloudRailServices;
110107
private PDKClient pdkClient;
111108
// private GoogleApiClient mGoogleApiClient;
112-
private DropboxAPI<AndroidAuthSession> mDBApi;
113109
private BoxSession sessionBox;
114110

115111
@Override
@@ -216,11 +212,7 @@ public int getNavigationMenuItemId() {
216212

217213
@Override
218214
public void onItemClick(final View childView, final int position) {
219-
ConnectivityManager cm=(ConnectivityManager)context.getSystemService(Context.CONNECTIVITY_SERVICE);
220-
NetworkInfo ni = cm.getActiveNetworkInfo();
221-
if (ni == null) {
222-
Snackbar.make(findViewById(android.R.id.content),getString(R.string.internet_is_off),Snackbar.LENGTH_SHORT).show();
223-
}
215+
if (!checkNetwork(this,parentLayout)) return;
224216
final SwitchCompat signInSignOut = childView.findViewById(R.id.sign_in_sign_out_switch);
225217
final String name = AccountDatabase.AccountName.values()[position].toString();
226218

@@ -287,9 +279,6 @@ public void onItemClick(final View childView, final int position) {
287279
/*case ONEDRIVE:
288280
signInOneDrive();
289281
break;*/
290-
291-
default:
292-
SnackBarHandler.show(coordinatorLayout, R.string.feature_not_present);
293282
}
294283
} else {
295284
AlertDialog alertDialog = new AlertDialog.Builder(this)
@@ -468,7 +457,7 @@ public void callBack(int status, Object data) {
468457
}
469458

470459
private void signInPinterest() {
471-
ArrayList<String> scopes = new ArrayList<String>();
460+
ArrayList<String> scopes = new ArrayList<>();
472461
scopes.add(PDKClient.PDKCLIENT_PERMISSION_READ_PUBLIC);
473462
scopes.add(PDKClient.PDKCLIENT_PERMISSION_WRITE_PUBLIC);
474463
scopes.add(PDKClient.PDKCLIENT_PERMISSION_READ_RELATIONSHIPS);

‎app/src/main/java/org/fossasia/phimpme/accounts/AccountPresenter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,6 @@ public boolean checkAlreadyExist(AccountDatabase.AccountName s) {
5656
RealmResults<AccountDatabase> result1 = query.findAll();
5757

5858
// Here checking if count of that values is greater than zero
59-
return (result1.size() > 0) ? true : false;
59+
return result1.size() > 0;
6060
}
6161
}

‎app/src/main/java/org/fossasia/phimpme/base/BaseActivity.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ protected void onCreate(Bundle savedInstanceState) {
6161
nav_cam = findViewById(R.id.navigation_camera);
6262
nav_acc = findViewById(R.id.navigation_accounts);
6363

64-
int checkStoragePermission = ContextCompat.checkSelfPermission(this, android.Manifest.permission.WRITE_EXTERNAL_STORAGE);
64+
int checkStoragePermission = ContextCompat.checkSelfPermission(this, android.Manifest.permission.READ_EXTERNAL_STORAGE);
6565
if(checkStoragePermission == PackageManager.PERMISSION_GRANTED)
6666
presentShowcaseSequence(); // one second delay
6767

0 commit comments

Comments
 (0)