-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bottomBar Slide Animation #2925
Open
satyajiit
wants to merge
7
commits into
fossasia:development
Choose a base branch
from
satyajiit:fixedBtmBarSlide
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Image Delete Issue , TrashBin Issue and More Clicking on Delete Icon on the Toolbar now deletes all the images. Fixed issue when images of same name are added by changing the PrimaryKey from binPath to an auto_increment id. Fixed an issue in which files are not deleted from ".nomedia" directory. Also Updated some external library versions. Fixed Image Delete Issue , TrashBin Issue and More Clicking on Delete Icon on the Toolbar now deletes all the images. Fixed issue when images of same name are added by changing the PrimaryKey from binPath to an auto_increment id. Fixed an issue in which files are not deleted from ".nomedia" directory. Also Updated some external library versions. Update build.gradle Origin
rob729
reviewed
Nov 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@satyajiit Squash these commits into a single commit
@rob729 is it fine now? |
yashk2000
approved these changes
Nov 21, 2019
codedsun
suggested changes
Nov 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use base activity instead of application class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2923
Changes: Added a global variable to MyApplication Class.
And applied transition based on logic/conditions to each of the three activities.
Since we have three NavItems NavItem starts from zero to two.
Added four new anim xml files and deleted the old two.
GIF :
Thank you @codedsun for your valuable feedback and review on this issue. 🙂