Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy CHANGELOG to build directory if available #946

Open
PickMeNow opened this issue Sep 30, 2024 · 6 comments
Open

Copy CHANGELOG to build directory if available #946

PickMeNow opened this issue Sep 30, 2024 · 6 comments
Labels

Comments

@PickMeNow
Copy link

Hi,

Will trying to update thorium-browser-bin, it seems aura is unable to download the full snapshot of the package:

aura :: Building thorium-browser-bin...
aura :: Edit the PKGBUILD? [Y/n] y
/home/me/.cache/aura/builds/thorium-browser-bin/PKGBUILD: line 22: /home/me/.cache/aura/builds/thorium-browser-bin/PKGBUILD.base: No such file or directory
==> ERROR: Failed to source /home/me/.cache/aura/builds/thorium-browser-bin/PKGBUILD
aura :: Package failed to build, citing:

makepkg failed.

aura :: Action cancelled.

Seems to be a bug associated with aura.
Link of the package: https://aur.archlinux.org/packages/thorium-browser-bin

Already reported to the maintainer as well.

@xiota
Copy link

xiota commented Sep 30, 2024

I am the current maintainer of aur/thorium-browser-bin. Build failure with aura was result of recent change to support multiple architectures. The primary PKGBUILD passes control to auxiliary PKGBUILDs based on CARCH. This avoids spreading complicated logic throughout a single PKGBUILD.

I have a potential workaround that I will probably test and apply in upcoming days. However, another package is likely also affected (aur/glibc-eac-roco), and the workaround cannot be applied. I am unaware of any other affected packages, but the usual expectation is for a complete snapshot or clone to be downloaded.

yay, paru, makepkg, and pkgctl successfully build thorium-browser-bin.

@fosskers
Copy link
Owner

fosskers commented Oct 1, 2024

Aura only copies over PKGBUILD from its initial clone location to its build directory. It doesn't expect there to ever be more than one such file, and this is the first time I've heard of it happening. I'll think about this.

@xiota
Copy link

xiota commented Oct 1, 2024

While testing PKGBUILDs, found that changelog="changes.txt" does not copy the file to the build directory. The file exists, is an ordinary text file, and is readable. .SRCINFO was updated prior to attempt. makepkg successfully builds the package in place. While changelog is part of PKGBUILD specification, I've never seen it used in an actual package.

Clarification: Referring to build attempt with aura -A pkg. Following error was produced:

==> ERROR: changelog file (changes.txt) does not exist or is not a regular file.

@fosskers
Copy link
Owner

fosskers commented Oct 1, 2024

I've attempted to use the changelog field before with mixed success. -Qc displays it if present, but as you point out and as far as I know, most packages don't include it.

@xiota
Copy link

xiota commented Oct 17, 2024

thorium-browser-bin and glibc-eac-roco have been updated so that Aura can build them, so the original issue may be considered resolved. However, the problem with changelog should be addressed (by processing similarly to install) because it is part of the PKGBUILD specification.

@fosskers
Copy link
Owner

This just bit me this morning when attempting to build Anki.

@fosskers fosskers added the bug label Oct 20, 2024
@fosskers fosskers changed the title aura does not download a full snapshot or clone of the package. Copy CHANGELOG to build directory if available Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants