You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
t:concatenate is bound to using lists as input, which doesn't make sense when all inputs are vectors and the reducer is t:vector. Should t:concatenate look at input to determine if t:list-reduce or t:vector-reduce should be used? Or hardcode knowledge of t:vector as reducer to convert input to a vector if needed?
I just copy/pasted t:concatenate to a version using t:vector-reduce and use that, but it's a bit dirty.
The text was updated successfully, but these errors were encountered:
Check out the first-pass of the PR I just pushed. I still need to add a proper Condition for when the input isn't a list/vector/string, as well as some unit tests.
t:concatenate
is bound to using lists as input, which doesn't make sense when all inputs are vectors and the reducer ist:vector
. Shouldt:concatenate
look atinput
to determine ift:list-reduce
ort:vector-reduce
should be used? Or hardcode knowledge oft:vector
asreducer
to convertinput
to a vector if needed?I just copy/pasted
t:concatenate
to a version usingt:vector-reduce
and use that, but it's a bit dirty.The text was updated successfully, but these errors were encountered: