Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to tuning/utils/config_utils.py #75

Open
tedhtchang opened this issue Mar 5, 2024 · 5 comments
Open

Add unit tests to tuning/utils/config_utils.py #75

tedhtchang opened this issue Mar 5, 2024 · 5 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@tedhtchang
Copy link
Collaborator

tedhtchang commented Mar 5, 2024

Is your feature request related to a problem? Please describe.

Add unit tests for the tuning/utils/config_utils.py module.

Describe the solution you'd like

If possible, each function should have test cases in the file tests/tuning/utils/test_config_utils.py
and pass test with the command pytest tests/tuning/utils/test_config_utils.py

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context about the feature request here.

@Ssukriti
Copy link
Collaborator

Ssukriti commented Mar 8, 2024

@tedhtchang or @jbusche I think one of you can take this , as it should not need full knowledge of the repository and should be easier

@Ssukriti Ssukriti added the good first issue Good for newcomers label Mar 11, 2024
@twumasipennoh
Copy link

Hi @Ssukriti can I take this one?

@Ssukriti
Copy link
Collaborator

a pull request is already created for this which is under review #85
If there are review changes suggested in the next week, you could work on that maybe?

@twumasipennoh
Copy link

Ok I will look out for new issues. Thank you

@Ssukriti
Copy link
Collaborator

seems like the PR tested the config but not the config utilities https://github.com/foundation-model-stack/fms-hf-tuning/blob/main/tuning/utils/config_utils.py

so this issue still needs works as tests for utilities are missing

@aluu317 aluu317 self-assigned this Jul 24, 2024
@aluu317 aluu317 mentioned this issue Jul 24, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants