feat: add explicit_iter_loop clippy lint (#10146)

Author: taikoonwang

Diff for: Cargo.toml

@@ -39,6 +39,7 @@ exclude = ["benches/", "tests/", "test-data/", "testdata/"]
 
 [workspace.lints.clippy]
 dbg-macro = "warn"
+explicit_iter_loop = "warn"
 manual-string-new = "warn"
 uninlined-format-args = "warn"
 use-self = "warn"

Diff for: crates/anvil/src/eth/backend/genesis.rs

@@ -50,7 +50,7 @@ impl GenesisConfig {
                 // insert all accounts
                 db.insert_account(addr, self.genesis_to_account_info(&acc));
                 // insert all storage values
-                for (k, v) in storage.unwrap_or_default().iter() {
+                for (k, v) in &storage.unwrap_or_default() {
                     db.set_storage_at(addr, *k, *v)?;
                 }
             }

Diff for: crates/anvil/src/eth/backend/mem/state.rs

@@ -79,7 +79,7 @@ where
     D: DatabaseRef<Error = DatabaseError>,
 {
     let mut cache_db = CacheDB::new(state);
-    for (account, account_overrides) in overrides.iter() {
+    for (account, account_overrides) in &overrides {
         let mut account_info = cache_db.basic_ref(*account)?.unwrap_or_default();
 
         if let Some(nonce) = account_overrides.nonce {
@@ -114,7 +114,7 @@ where
                 )?;
             }
             (None, Some(account_state_diff)) => {
-                for (key, value) in account_state_diff.iter() {
+                for (key, value) in account_state_diff {
                     cache_db.insert_account_storage(*account, (*key).into(), (*value).into())?;
                 }
             }

Diff for: crates/anvil/src/eth/backend/mem/storage.rs

@@ -373,7 +373,7 @@ impl BlockchainStorage {
     /// Removes all stored transactions for the given block hash
     pub fn remove_block_transactions(&mut self, block_hash: B256) {
         if let Some(block) = self.blocks.get_mut(&block_hash) {
-            for tx in block.transactions.iter() {
+            for tx in &block.transactions {
                 self.transactions.remove(&tx.hash());
             }
             block.transactions.clear();
@@ -419,7 +419,7 @@ impl BlockchainStorage {
 
     /// Deserialize and add all blocks data to the backend storage
     pub fn load_blocks(&mut self, serializable_blocks: Vec<SerializableBlock>) {
-        for serializable_block in serializable_blocks.iter() {
+        for serializable_block in &serializable_blocks {
             let block: Block = serializable_block.clone().into();
             let block_hash = block.header.hash_slow();
             let block_number = block.header.number;
@@ -430,7 +430,7 @@ impl BlockchainStorage {
 
     /// Deserialize and add all blocks data to the backend storage
     pub fn load_transactions(&mut self, serializable_transactions: Vec<SerializableTransaction>) {
-        for serializable_transaction in serializable_transactions.iter() {
+        for serializable_transaction in &serializable_transactions {
             let transaction: MinedTransaction = serializable_transaction.clone().into();
             self.transactions.insert(transaction.info.transaction_hash, transaction);
         }

Diff for: crates/anvil/src/lib.rs

@@ -434,7 +434,7 @@ impl Future for NodeHandle {
         }
 
         // poll the axum server handles
-        for server in pin.servers.iter_mut() {
+        for server in &mut pin.servers {
             if let Poll::Ready(res) = server.poll_unpin(cx) {
                 return Poll::Ready(res);
             }

Diff for: crates/cheatcodes/src/evm/record_debug_step.rs

@@ -41,7 +41,7 @@ fn recursive_flatten_call_trace<'a>(
 
     let node = &arena.nodes()[node_idx];
 
-    for order in node.ordering.iter() {
+    for order in &node.ordering {
         match order {
             TraceMemberOrder::Step(step_idx) => {
                 if *record_started {

Diff for: crates/cli/src/opts/dependency.rs

@@ -65,7 +65,7 @@ impl FromStr for Dependency {
             let mut dependency = dependency.to_string();
             // this will autocorrect wrong conventional aliases for tag, but only autocorrect if
             // it's not used as alias
-            for (alias, real_org) in COMMON_ORG_ALIASES.iter() {
+            for (alias, real_org) in COMMON_ORG_ALIASES {
                 if dependency.starts_with(alias) {
                     dependency = dependency.replacen(alias, real_org, 1);
                     break

Diff for: crates/cli/src/utils/cmd.rs

@@ -80,8 +80,8 @@ pub fn get_cached_entry_by_name(
     let mut cached_entry = None;
     let mut alternatives = Vec::new();
 
-    for (abs_path, entry) in cache.files.iter() {
-        for (artifact_name, _) in entry.artifacts.iter() {
+    for (abs_path, entry) in &cache.files {
+        for artifact_name in entry.artifacts.keys() {
             if artifact_name == name {
                 if cached_entry.is_some() {
                     eyre::bail!(
@@ -124,7 +124,7 @@ pub fn ensure_clean_constructor(abi: &JsonAbi) -> Result<()> {
 pub fn needs_setup(abi: &JsonAbi) -> bool {
     let setup_fns: Vec<_> = abi.functions().filter(|func| func.name.is_setup()).collect();
 
-    for setup_fn in setup_fns.iter() {
+    for setup_fn in &setup_fns {
         if setup_fn.name != "setUp" {
             let _ = sh_warn!(
                 "Found invalid setup function \"{}\" did you mean \"setUp()\"?",

Diff for: crates/common/fmt/src/ui.rs

@@ -291,7 +291,7 @@ impl UIfmt for OtherFields {
         if !self.is_empty() {
             s.push('\n');
         }
-        for (key, value) in self.iter() {
+        for (key, value) in self {
             let val = EthValue::from(value.clone()).pretty();
             let offset = NAME_COLUMN_LEN.saturating_sub(key.len());
             s.push_str(key);

Diff for: crates/common/src/compile.rs

@@ -507,7 +507,7 @@ pub fn etherscan_project(
     let mut settings = metadata.settings()?;
 
     // make remappings absolute with our root
-    for remapping in settings.remappings.iter_mut() {
+    for remapping in &mut settings.remappings {
         let new_path = sources_path.join(remapping.path.trim_start_matches('/'));
         remapping.path = new_path.display().to_string();
     }

Diff for: crates/common/src/provider/runtime_transport.rs

@@ -165,7 +165,7 @@ impl RuntimeTransport {
         };
 
         // Add any custom headers.
-        for header in self.headers.iter() {
+        for header in &self.headers {
             let make_err = || RuntimeTransportError::BadHeader(header.to_string());
 
             let (key, val) = header.split_once(':').ok_or_else(make_err)?;

Diff for: crates/config/src/inline/natspec.rs

@@ -123,7 +123,7 @@ impl SolcParser {
     /// Given a list of nodes, find a "ContractDefinition" node that matches
     /// the provided contract_id.
     fn contract_root_node<'a>(&self, nodes: &'a [Node], contract_id: &str) -> Option<&'a Node> {
-        for n in nodes.iter() {
+        for n in nodes {
             if n.node_type == NodeType::ContractDefinition {
                 let contract_data = &n.other;
                 if let Value::String(contract_name) = contract_data.get("name")? {
@@ -145,7 +145,7 @@ impl SolcParser {
                 natspecs.push(NatSpec { contract: contract.into(), function: None, docs, line })
             }
         }
-        for n in node.nodes.iter() {
+        for n in &node.nodes {
             if let Some((function, docs, line)) = self.get_fn_data(n) {
                 natspecs.push(NatSpec {
                     contract: contract.into(),

Diff for: crates/config/src/providers/ext.rs

@@ -545,7 +545,7 @@ impl<P: Provider> Provider for FallbackProfileProvider<P> {
         let data = self.provider.data()?;
         if let Some(fallback) = data.get(&self.fallback) {
             let mut inner = data.get(&self.profile).cloned().unwrap_or_default();
-            for (k, v) in fallback.iter() {
+            for (k, v) in fallback {
                 if !inner.contains_key(k) {
                     inner.insert(k.to_owned(), v.clone());
                 }

Diff for: crates/debugger/src/node.rs

@@ -44,7 +44,7 @@ pub fn flatten_call_trace(arena: CallTraceArena, out: &mut Vec<DebugNode>) {
     fn inner(arena: &CallTraceArena, node_idx: usize, out: &mut Vec<PendingNode>) {
         let mut pending = PendingNode { node_idx, steps_count: 0 };
         let node = &arena.nodes()[node_idx];
-        for order in node.ordering.iter() {
+        for order in &node.ordering {
             match order {
                 TraceMemberOrder::Call(idx) => {
                     out.push(pending);

Diff for: crates/doc/src/parser/mod.rs

@@ -133,7 +133,7 @@ impl Visitor for Parser {
     type Error = ParserError;
 
     fn visit_source_unit(&mut self, source_unit: &mut SourceUnit) -> ParserResult<()> {
-        for source in source_unit.0.iter_mut() {
+        for source in &mut source_unit.0 {
             match source {
                 SourceUnitPart::ContractDefinition(def) => {
                     // Create new contract parse item.
@@ -184,7 +184,7 @@ impl Visitor for Parser {
         // If the function parameter doesn't have a name, try to set it with
         // `@custom:name` tag if any was provided
         let mut start_loc = func.loc.start();
-        for (loc, param) in func.params.iter_mut() {
+        for (loc, param) in &mut func.params {
             if let Some(param) = param {
                 if param.name.is_none() {
                     let docs = self.parse_docs_range(start_loc, loc.end())?;

Diff for: crates/doc/src/preprocessor/contract_inheritance.rs

@@ -26,13 +26,13 @@ impl Preprocessor for ContractInheritance {
     }
 
     fn preprocess(&self, documents: Vec<Document>) -> Result<Vec<Document>, eyre::Error> {
-        for document in documents.iter() {
+        for document in &documents {
             if let DocumentContent::Single(ref item) = document.content {
                 if let ParseSource::Contract(ref contract) = item.source {
                     let mut links = HashMap::default();
 
                     // Attempt to match bases to other contracts
-                    for base in contract.base.iter() {
+                    for base in &contract.base {
                         let base_ident = base.name.identifiers.last().unwrap().name.clone();
                         if let Some(linked) = self.try_link_base(&base_ident, &documents) {
                             links.insert(base_ident, linked);

Diff for: crates/doc/src/preprocessor/deployments.rs

@@ -55,7 +55,7 @@ impl Preprocessor for Deployments {
             .collect::<Result<Vec<_>, _>>()?;
 
         // Iterate over all documents to find any deployments.
-        for document in documents.iter() {
+        for document in &documents {
             let mut deployments = Vec::default();
 
             // Iterate over all networks and check if there is a deployment for the given contract.

Diff for: crates/doc/src/preprocessor/git_source.rs

@@ -27,7 +27,7 @@ impl Preprocessor for GitSource {
         if let Some(ref repo) = self.repository {
             let repo = repo.trim_end_matches('/');
             let commit = self.commit.clone().unwrap_or("master".to_owned());
-            for document in documents.iter() {
+            for document in &documents {
                 if document.from_library {
                     continue;
                 }

Diff for: crates/doc/src/preprocessor/inheritdoc.rs

@@ -23,7 +23,7 @@ impl Preprocessor for Inheritdoc {
     }
 
     fn preprocess(&self, documents: Vec<Document>) -> Result<Vec<Document>, eyre::Error> {
-        for document in documents.iter() {
+        for document in &documents {
             if let DocumentContent::Single(ref item) = document.content {
                 let context = self.visit_item(item, &documents);
                 if !context.is_empty() {
@@ -50,7 +50,7 @@ impl Inheritdoc {
         }
 
         // Match item's children.
-        for ch in item.children.iter() {
+        for ch in &item.children {
             let matched = ch
                 .comments
                 .find_inheritdoc_base()
@@ -76,7 +76,7 @@ impl Inheritdoc {
                         // Not matched for the contract because it's a noop
                         // https://docs.soliditylang.org/en/v0.8.17/natspec-format.html#tags
 
-                        for children in item.children.iter() {
+                        for children in &item.children {
                             // TODO: improve matching logic
                             if source.ident() == children.source.ident() {
                                 let key = format!("{}.{}", base, source.ident());

Diff for: crates/doc/src/writer/as_doc.rs

@@ -96,7 +96,7 @@ impl AsDoc for Document {
                     writer.writeln()?;
                 }
 
-                for item in items.iter() {
+                for item in items {
                     let func = item.as_function().unwrap();
                     let mut heading = item.source.ident();
                     if !func.params.is_empty() {
@@ -119,7 +119,7 @@ impl AsDoc for Document {
                     writer.writeln()?;
                 }
 
-                for item in items.iter() {
+                for item in items {
                     let var = item.as_variable().unwrap();
                     writer.write_heading(&var.name.safe_unwrap().name)?;
                     writer.write_section(&item.comments, &item.code)?;
@@ -147,7 +147,7 @@ impl AsDoc for Document {
                             let mut bases = vec![];
                             let linked =
                                 read_context!(self, CONTRACT_INHERITANCE_ID, ContractInheritance);
-                            for base in contract.base.iter() {
+                            for base in &contract.base {
                                 let base_doc = base.as_doc()?;
                                 let base_ident = &base.name.identifiers.last().unwrap().name;
 
@@ -193,7 +193,7 @@ impl AsDoc for Document {
                         if let Some(funcs) = item.functions() {
                             writer.write_subtitle("Functions")?;
 
-                            for (func, comments, code) in funcs.iter() {
+                            for (func, comments, code) in &funcs {
                                 self.write_function(&mut writer, func, comments, code)?;
                             }
                         }

Diff for: crates/evm/core/src/backend/mod.rs

@@ -1182,7 +1182,7 @@ impl DatabaseExt for Backend {
                 // Special case for accounts that are not created: we don't merge their state but
                 // load it in order to reflect their state at the new block (they should explicitly
                 // be marked as persistent if it is desired to keep state between fork rolls).
-                for (addr, acc) in journaled_state.state.iter() {
+                for (addr, acc) in &journaled_state.state {
                     if acc.is_created() {
                         if acc.is_touched() {
                             merge_journaled_state_data(
@@ -1375,7 +1375,7 @@ impl DatabaseExt for Backend {
         journaled_state: &mut JournaledState,
     ) -> Result<(), BackendError> {
         // Loop through all of the allocs defined in the map and commit them to the journal.
-        for (addr, acc) in allocs.iter() {
+        for (addr, acc) in allocs {
             self.clone_account(acc, addr, journaled_state)?;
         }
 
@@ -1967,7 +1967,7 @@ pub fn update_state<DB: Database>(
     for (addr, acc) in state.iter_mut() {
         if !persistent_accounts.is_some_and(|accounts| accounts.contains(addr)) {
             acc.info = db.basic(*addr)?.unwrap_or_default();
-            for (key, val) in acc.storage.iter_mut() {
+            for (key, val) in &mut acc.storage {
                 val.present_value = db.storage(*addr, *key)?;
             }
         }

Diff for: crates/evm/core/src/fork/multi.rs

@@ -256,7 +256,7 @@ impl MultiForkHandler {
 
     /// Returns the list of additional senders of a matching task for the given id, if any.
     fn find_in_progress_task(&mut self, id: &ForkId) -> Option<&mut Vec<CreateSender>> {
-        for task in self.pending_tasks.iter_mut() {
+        for task in &mut self.pending_tasks {
             #[allow(irrefutable_let_patterns)]
             if let ForkTask::Create(_, in_progress, _, additional) = task {
                 if in_progress == id {

Diff for: crates/evm/evm/src/executors/invariant/mod.rs

@@ -801,7 +801,7 @@ impl<'a> InvariantExecutor<'a> {
         address: Address,
         targeted_contracts: &mut TargetedContracts,
     ) -> Result<()> {
-        for (address, (identifier, _)) in self.setup_contracts.iter() {
+        for (address, (identifier, _)) in self.setup_contracts {
             if let Some(selectors) = self.artifact_filters.targeted.get(identifier) {
                 self.add_address_with_functions(*address, selectors, false, targeted_contracts)?;
             }

Diff for: crates/evm/fuzz/src/invariant/mod.rs

@@ -84,7 +84,7 @@ impl FuzzRunIdentifiedContracts {
     pub fn clear_created_contracts(&self, created_contracts: Vec<Address>) {
         if !created_contracts.is_empty() {
             let mut targets = self.targets.lock();
-            for addr in created_contracts.iter() {
+            for addr in &created_contracts {
                 targets.remove(addr);
             }
         }

Diff for: crates/evm/traces/src/decoder/mod.rs

@@ -318,7 +318,7 @@ impl CallTraceDecoder {
     pub async fn populate_traces(&self, traces: &mut Vec<CallTraceNode>) {
         for node in traces {
             node.trace.decoded = self.decode_function(&node.trace).await;
-            for log in node.logs.iter_mut() {
+            for log in &mut node.logs {
                 log.decoded = self.decode_event(&log.raw_log).await;
             }
 
@@ -682,7 +682,7 @@ fn reconstruct_params(event: &Event, decoded: &DecodedEvent) -> Vec<DynSolValue>
     let mut indexed = 0;
     let mut unindexed = 0;
     let mut inputs = vec![];
-    for input in event.inputs.iter() {
+    for input in &event.inputs {
         // Prevent panic of event `Transfer(from, to)` decoded with a signature
         // `Transfer(address indexed from, address indexed to, uint256 indexed tokenId)` by making
         // sure the event inputs is not higher than decoded indexed / un-indexed values.

Diff for: crates/evm/traces/src/folded_stack_trace.rs

@@ -181,7 +181,7 @@ impl FoldedStackTraceBuilder {
     /// the children function calls.
     fn build_without_subtraction(&mut self) -> Vec<String> {
         let mut lines = Vec::new();
-        for TraceEntry { names, gas } in self.traces.iter() {
+        for TraceEntry { names, gas } in &self.traces {
             lines.push(format!("{} {}", names.join(";"), gas));
         }
         lines

Diff for: crates/fmt/src/buffer.rs

@@ -431,7 +431,7 @@ mod tests {
             /* comment2 */ ",
         ];
 
-        for content in contents.iter() {
+        for content in &contents {
             let mut buf = FormatBuffer::new(String::new(), TAB_WIDTH);
             write!(buf, "{content}")?;
             assert_eq!(&buf.w, content);

Diff for: crates/fmt/src/formatter.rs

@@ -1849,7 +1849,7 @@ impl<'a, W: Write> Formatter<'a, W> {
         }
 
         // order all groups alphabetically
-        for group in import_groups.iter() {
+        for group in &import_groups {
             // SAFETY: group is not empty
             let first = group[0];
             let last = group.last().copied().expect("group is not empty");

Diff for: crates/forge/src/cmd/clone.rs

@@ -799,7 +799,7 @@ mod tests {
     }
 
     fn pick_creation_info(address: &str) -> Option<(&'static str, &'static str)> {
-        for (addr, contract_name, creation_code) in CREATION_ARRAY.iter() {
+        for (addr, contract_name, creation_code) in &CREATION_ARRAY {
             if address == *addr {
                 return Some((contract_name, creation_code));
             }