Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor changed CIM plugin behaviour #31

Open
JSCU-CNI opened this issue Feb 19, 2025 · 0 comments
Open

Refactor changed CIM plugin behaviour #31

JSCU-CNI opened this issue Feb 19, 2025 · 0 comments

Comments

@JSCU-CNI
Copy link
Contributor

The following change in #27 modified the behaviour of DataRegion.get_value:

7398596#diff-e5afd30094460643d9391ddeccd8dd021e5dde2df200d43b8bd080ea477f0fbfR411-R418

-        else:
-            ValueError("Unknown value type")
+
+        raise ValueError("Unknown value type")

It turns out often occurring integer types such as CIM_TYPES.UINT16 are not extracted. This proably failed silently before but now breaks the dissect.target cim.consumerbindings plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant