Refine DLM lifecycle modules.

The original design has implict dependencies between `dlm-lifecycle-iam-role` and `dlm-lifecycle-policy` on IAM role. But TF currently does not support module dependency, and it does not get the dependency when a module is depends on another resource's `name` output.

So merged the two modules to avoid applying error that "the role does not exist".

Author: Magicloud

modules/dlm-lifecycle-iam-role/README.md

@@ -1,9 +1,3 @@
-variable "iam_role_name" {
-  description = "The IAM role name for the DLM lifecyle policy"
-  type        = string
-  default     = "dlm-lifecycle-role"
-}
-
 # Create the iam role
 resource "aws_iam_role" "dlm_lifecycle_role" {
   name                = var.iam_role_name
@@ -54,3 +48,4 @@ resource "aws_iam_role_policy" "dlm_lifecycle_policy" {
 }
 EOF
 }
+

modules/dlm-lifecycle-iam-role/versions.tf

@@ -11,15 +11,10 @@
 *
 */
 
-# Get the data of role to pass the resource
-data "aws_iam_role" "dlm_lifecycle_role" {
-  name         = var.role_name
-}
-
 # DLM lifecycle schedule
 resource "aws_dlm_lifecycle_policy" "ebs-lifecycle-policy" {
   description        = var.description
-  execution_role_arn = data.aws_iam_role.dlm_lifecycle_role.arn
+  execution_role_arn = aws_iam_role.dlm_lifecycle_role.arn
   state              = "ENABLED"
 
   policy_details {

modules/dlm-lifecycle-iam-role/main.tf modules/dlm-lifecycle-policy/iam.tf

@@ -63,7 +63,8 @@ variable "policy_tags_to_add" {
   default     = {"SnapshotCreator" = "DLM lifecycle"}
 }
 
-variable "role_name" {
+variable "iam_role_name" {
   description = "The IAM role name for the DLM lifecyle policy"
   type        = string
+  default     = "dlm-lifecycle-role"
 }