Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use Moment objects, use dates! #318

Open
ghost opened this issue Sep 21, 2020 · 1 comment
Open

Do not use Moment objects, use dates! #318

ghost opened this issue Sep 21, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented Sep 21, 2020

I don't understand why an AngularJS library needs to manage dates as Moment objects. For example, it is wrong for filters. Here is a demo.
@ghost ghost changed the title Do not user Moment objects, use dates! Do not use Moment objects, use dates! Sep 21, 2020
@ghost
Copy link
Author

ghost commented Sep 21, 2020

Besides, if dates (startDate and/or endDate) are defined with dates, it fails. For avoid this, it is necessary some code like: Date.prototype.isValid = angular.noop;.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants