Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try GitHub Actions by migrating updater-gui-tests and rust jobs #6732

Closed
wants to merge 2 commits into from

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Jan 20, 2023

Status

Ready for review

Description of Changes

Try GitHub Actions by migrating updater-gui-tests and rust jobs

The syntax is fairly close, so no actual changes were needed to the commands that are run.

I did switch usage of apt to apt-get since the former isn't supposed to be used in scripts.

I intentionally chose to not migrate the branch filter over to reduce complexity given how fast and light this job is.

Testing

  • CI passes

Deployment

Any special considerations for deployment? No.

Checklist

n/a

@legoktm legoktm requested a review from a team as a code owner January 20, 2023 22:47
@legoktm
Copy link
Member Author

legoktm commented Jan 20, 2023

One weird thing is that GH Actions will now run the job twice, once for the branch push inside the securedrop repo, and then again for the pull request. For quick jobs like this it's not an issue, but it could get annoying for longer ones.

@legoktm
Copy link
Member Author

legoktm commented Jan 20, 2023

@legoktm legoktm marked this pull request as draft January 20, 2023 22:56
@gonzalo-bulnes
Copy link
Contributor

I too have noticed the double run (without taking action on it for my repos). Additionally, note that if tou want to (re-)trigger workflows manually for whatever reason, they must be configured to trigger on the workflow_dispatch event.

@legoktm
Copy link
Member Author

legoktm commented Jan 23, 2023

Additionally, note that if tou want to (re-)trigger workflows manually for whatever reason, they must be configured to trigger on the workflow_dispatch event.

When I visit https://github.com/freedomofpress/securedrop/actions/runs/3971850268/jobs/6809178862 I see a "Re-run all jobs", did you mean something different?

@gonzalo-bulnes
Copy link
Contributor

Nope, if tou see the buttons, that was it. For some reason I had to enable that manually in my workflows... and found that explanation in GitHub's Help pages.

@legoktm legoktm marked this pull request as ready for review June 22, 2023 19:35
@legoktm legoktm changed the title Try GitHub Actions by migrating updater-gui-tests job Try GitHub Actions by migrating updater-gui-tests and rust jobs Jun 22, 2023
The syntax is fairly close, so no actual changes were needed to
the commands that are run.

I did switch usage of `apt` to `apt-get` since the former isn't
supposed to be used in scripts.

I intentionally chose to not migrate the branch filter over to
reduce complexity given how fast and light this job is.
@legoktm
Copy link
Member Author

legoktm commented Oct 4, 2023

Moving back to draft state, this needs to be updated and reconciled with #6969. (Maybe squashed into that PR?)

@legoktm legoktm marked this pull request as draft October 4, 2023 20:42
@legoktm
Copy link
Member Author

legoktm commented Oct 12, 2023

I'm redoing these commits in #6969.

@legoktm legoktm closed this Oct 12, 2023
@legoktm legoktm deleted the gh-actions branch October 12, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants