fix(ai): warn 'missing shfmt/safecmd' instead of 'Missing ai addon' + ship shfmt via the ai addon

[ocervell]

Problem (hit during CLI testing)

In attack mode every shell command the LLM issues hit the guardrail shell parser, which printed:

[ERR] Missing ai addon: please run "secator install addons ai".

…even though the ai addon was installed. _parse_subcommands (guardrails.py) shells out to shfmt via safecmd; the misleading message came from its ImportError branch. The env had litellm (so ADDONS_ENABLED['ai']=True) but not safecmd/shfmt — a partial ai install. Worse, the other failure mode (safecmd present, shfmt binary not on PATH) was silent (FileNotFoundError swallowed by except Exception: return []).

Fix

1. Message — replace the Error("Missing ai addon") with a one-shot Warning that names the real gap: "Missing safecmd shell parser" (ImportError) or "Missing shfmt binary" (FileNotFoundError). Both fall back to the non-shfmt path — an empty sub-command list, so _check_action_type asks the user to approve the whole command (safe, just coarser). Warn once per process (no per-command spam).
2. Install — add shfmt-py explicitly to the ai extra so secator install addons ai (pip install secator[ai]) always ships the shfmt binary, not just the safecmd Python package (which only pulled it transitively).

Tests

TestShellParserFallback: safecmd-missing → Warning naming safecmd, never "ai addon"; shfmt-binary-missing → Warning naming shfmt; warn-once across multiple commands. Full AI suite: no new failures vs branch baseline.

Found while testing ai-testing; targets ai-resiliency (#1241).

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7ffbc07e-11c7-4ccd-af9f-992209057189

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ai-guardrail-shfmt-warning

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}