Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we remove the string type at the end of DisplayProperty? #64

Closed
vensa-albertgao opened this issue Jan 9, 2019 · 2 comments
Closed

Comments

@vensa-albertgao
Copy link

export type DisplayProperty = Globals | DisplayOutside | DisplayInside | DisplayInternal | DisplayLegacy | "contents" | "list-item" | "none" | string;

The extra string in the end simply disable the feature of type checking, now the display could be anything like foo or bar.

Furthermore, in Typescript, you can't get intellisense, because it could be anything.
Should we remove it? Or I miss something?

Thanks :)

@pelotom
Copy link
Collaborator

pelotom commented Jan 9, 2019

See #8, #57, #60.

@vensa-albertgao
Copy link
Author

Learned something! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants