Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React version dependency issue #924

Open
GadgetGeekUK opened this issue Feb 16, 2022 · 5 comments
Open

React version dependency issue #924

GadgetGeekUK opened this issue Feb 16, 2022 · 5 comments

Comments

@GadgetGeekUK
Copy link

On install I get the following:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.3.0" from [email protected]
npm ERR! node_modules/react-sortable-tree
npm ERR!   react-sortable-tree@"*" from the root project
@murfett-au
Copy link

I also get this error using React 17. Here is my package.json

{
  "name": "client-no-cra",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "start": "webpack-dev-server --open",
    "create": "webpack",
    "relay": "relay-compiler $@",
    "relay-watch": "relay-compiler --watch",
    "flow": "flow"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "dependencies": {
    "css-loader": "^6.6.0",
    "file-loader": "^6.2.0",
    "flow-bin": "^0.171.0",
    "graphql": "^16.3.0",
    "react": "^17.0.2",
    "react-dom": "^17.0.2",
    "react-relay": "^13.1.0",
    "react-router-dom": "^6.2.1",
    "relay-runtime": "^13.1.0",
    "style-loader": "^3.3.1",
    "styled-components": "^5.3.3"
  },
  "devDependencies": {
    "@babel/cli": "^7.17.0",
    "@babel/core": "^7.17.0",
    "@babel/plugin-transform-runtime": "^7.17.0",
    "@babel/preset-env": "^7.16.11",
    "@babel/preset-flow": "^7.16.7",
    "@babel/preset-react": "^7.16.7",
    "babel-loader": "^8.2.3",
    "babel-plugin-relay": "^13.1.0",
    "babel-plugin-styled-components": "^2.0.2",
    "html-webpack-plugin": "^5.5.0",
    "relay-compiler": "^13.1.0",
    "webpack": "^5.68.0",
    "webpack-cli": "^4.9.2",
    "webpack-dev-server": "^4.7.4"
  },
  "relay": {
    "src": "./src",
    "schema": "../schema/schema.for.reference.graphql",
    "exclude": [
      "**/node_modules/**",
      "**/__mocks__/**",
      "**/__generated__/**"
    ]
  }
}

@nosferatu500
Copy link

@Imaginativeone
Copy link

@nosferatu500 Does your fork resolve the React dependency issues?

@nosferatu500
Copy link

@Imaginativeone My fork has no issues with deps. I think you can get a warning in the case of React 18. In theory, it should work out of the box, but I have not tested it yet.

@FullstackJack
Copy link

I don't like that we're now resorting to custom forks. Project owner should delegate maintenance of this repo to the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants