Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network.Kademlia.Tree.delete is dead code #3

Open
froozen opened this issue May 17, 2016 · 0 comments
Open

Network.Kademlia.Tree.delete is dead code #3

froozen opened this issue May 17, 2016 · 0 comments

Comments

@froozen
Copy link
Owner

froozen commented May 17, 2016

By running dead-code-detection on my project, I discovered that the delete function in Network.Kademlia.Tree is dead code. My intuition tells me that this shouldn't be the case and I messed up the implementation of timing out peers.
taktoa referenced this issue in dfinity-lab/kademlia Sep 7, 2018
@georgeee
Merge pull request #3 from serokell/refactor
b9ed47c 
Add a flag to disable storing values in a specific instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@froozen