add mail conf task #1238
add mail conf task #1238
Conversation
actions/admin/settings/150.mail.php
Outdated
| 'settinggroup' => 'system', | ||
| 'varname' => 'mda_conf_dir', | ||
| 'type' => 'text', | ||
| 'string_type' => 'filedir', |
There was a problem hiding this comment.
Use string_type confdir here as this setting will not be a file and we want to check for disallowed paths, also, the (default) value should end with /
actions/admin/settings/150.mail.php
Outdated
| 'settinggroup' => 'system', | ||
| 'varname' => 'mta_conf_dir', | ||
| 'type' => 'text', | ||
| 'string_type' => 'filedir', |
There was a problem hiding this comment.
Same as mda conf dir, the type should be confdir and the default value should end with a /
| ('system', 'mdalog', '/var/log/mail.log'), | ||
| ('system', 'mtalog', '/var/log/mail.log'), | ||
| ('system', 'mdaserver', 'dovecot'), | ||
| ('system', 'mda_reload_command', 'service dovecot restart'), |
There was a problem hiding this comment.
missing mda_conf_dir and mta_conf_dir, also incrementing db_version is required for correct update handling
| Update::showUpdateStep("Adding new settings"); | ||
| Settings::AddNew("system.le_renew_services", ""); | ||
| Settings::AddNew("system.le_renew_hook", "systemctl restart postfix dovecot proftpd"); | ||
| Settings::AddNew("system.mda_reload_command", "service dovecot reload"); |
There was a problem hiding this comment.
a new update section with a new db-version is required or users on that version will not get the updates
| $vhosts_file_handler = fopen($vhosts_filename, 'w'); | ||
| fwrite($vhosts_file_handler, $vhosts_file); | ||
| fclose($vhosts_file_handler); | ||
| FileDir::safe_exec('postmap -F hash:'.$vhosts_filename); |
There was a problem hiding this comment.
how is this map integrated in the postfix config and being used?
There was a problem hiding this comment.
okay, missed the 'postconf -e tls_server_sni_maps' command there, sorry
| mv froxlor-nightly.${{steps.vars.outputs.sha_short}}.zip dist/ | ||
| mv froxlor-nightly.${{steps.vars.outputs.sha_short}}.zip.sha256 dist/ | ||
| - name: Deploy nightly to server |
There was a problem hiding this comment.
please dont change stuff in the build - this needs to be available on our servers for the update/autoupdate to work and does not have anything to do with the feature you are working on in any way
2 participants
set up certs for multiple domains in Postfix and Dovecot