Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't Input of Critic be hidden state of RNN? #5

Open
ychen306 opened this issue Nov 15, 2018 · 2 comments
Open

Shouldn't Input of Critic be hidden state of RNN? #5

ychen306 opened this issue Nov 15, 2018 · 2 comments

Comments

@ychen306
Copy link

ychen306 commented Nov 15, 2018

Hi Faraz,
I am studying the paper and your implementation is very helpful! I have a question though. It seems that the critic network in the paper takes in history -- which in this case is hidden state of the actor's LSTM, I presume -- rather than the observed state of the environment.

https://github.com/fshamshirdar/pytorch-rdpg/blob/master/rdpg.py#L139-L141

@HassamSheikh
Copy link

I was looking at exactly the same thing. Got your answer?

@zhihanyang2022
Copy link

I think this is a valid concern. Making state information available to the critic makes this implementation incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants