Generate test TLS certificates on demand #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsouza
force-pushed
the
remove-checked-in-pems
branch
from
cd47e3e to
18f42ee
Compare
fsouza
changed the title
This avoids having pem files that could expire and cause tests to randomly start failing. This makes tests slower, but computers are faster in 2025. If things are really bad, we could refactor to use TestMain and make one certificate rather than generating it on demand for tests, but I suspect this won't be necessary. Closes #1112.
fsouza
force-pushed
the
remove-checked-in-pems
branch
from
18f42ee to
911724f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids having pem files that could expire and cause tests to randomly start failing.
This makes tests slower, but computers are faster in 2025. If things are really bad, we could refactor to use TestMain and make one certificate rather than generating it on demand for tests, but I suspect this won't be necessary.
Closes #1112.