Skip to content
This repository has been archived by the owner on Apr 4, 2021. It is now read-only.

Use APOC CSV loader to generate expected results #176

Open
szarnyasg opened this issue Jul 1, 2017 · 3 comments
Open

Use APOC CSV loader to generate expected results #176

szarnyasg opened this issue Jul 1, 2017 · 3 comments
Assignees
Milestone

Comments

@szarnyasg
Copy link
Member

Our current workflow for generating expected test result looks as follows:

  1. Generate/handcraft the CSV files of the inputs.
  2. Fire up a Neo4j 3.0 instance with the Neo4j shell tools.
  3. Load the data with neo4j-import.
  4. Export the data to a GraphML file with neo4j-shell.
  5. Load it with the org.neo4j.shell.tools.imp.format.graphml.XmlGraphMLReader class of the import tools JAR.

This is far too complicated, so we should simplify this and load the data with Cypher instead. However, this would require us to implement 30+ LOAD CSV queries manually.

I discussed this on the Neo4j users slack and it seems that implementing a stored procedure would be the best way to do this: neo4j-contrib/neo4j-apoc-procedures#489

@szarnyasg szarnyasg self-assigned this Jul 1, 2017
@szarnyasg
Copy link
Member Author

szarnyasg commented Sep 6, 2017

The stored procedure is almost ready, but this will only be required by the Social Network Benchmark.

@szarnyasg szarnyasg modified the milestones: autumn, winter Sep 6, 2017
@szarnyasg szarnyasg modified the milestones: winter, autumn Sep 22, 2017
@szarnyasg
Copy link
Member Author

However, this would require us to implement 30+ LOAD CSV queries manually.

Okay, almost three month later I realized that we could just use APOC's GraphML export/import, which is a lot simpler.

@szarnyasg szarnyasg reopened this Oct 11, 2018
@szarnyasg
Copy link
Member Author

It turned out that GraphMLs are a lot more complicated to maintain (the CSVs are no longer a 'single source of truth'), so we should implement this, especially that neo4j-contrib/neo4j-apoc-procedures#489 was resolved this summer.

@szarnyasg szarnyasg changed the title Use LOAD CSV to generate expected results Use APOC CSV loader to generate expected results Oct 11, 2018
@szarnyasg szarnyasg modified the milestones: autumn 2017, autumn 2018 Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant