Fix Could not find goal 'verify' #180 (#181)

* Updated documentation #180

* Fix Could not find goal 'verify' #180

* log level warn if feature skipped #180

Author: fugerit79

CHANGELOG.md

@@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - fj-doc-maven-plugin is no on plugin management of fj-doc parent 
 - [fj-doc-sample] fj-doc-maven-plugin:verify configuration
 
+### Fixed
+
+- [fj-doc-maven-plugin] Could not find goal 'verify' <https://github.com/fugerit-org/fj-doc/issues/180>
+
 ## [8.7.4] - 2024-08-28
 
 ### Fixed

fj-doc-maven-plugin/src/main/java/org/fugerit/java/doc/project/facade/BasicVenusFacade.java

@@ -103,44 +103,50 @@ protected static void addExtensionList( File pomFile, VenusContext context ) thr
             }
         }
         log.info( "end dependencies size : {}", model.getDependencies().size() );
-        // addVerifyPlugin?
-        log.info( "addVerifyPlugin : {}", context.isAddVerifyPlugin() );
         addPlugin( context, model );
         try (OutputStream pomStream = new FileOutputStream( pomFile ) ) {
             modelIO.writeModelToStream( model, pomStream );
         }
     }
 
     private static void addPlugin( VenusContext context, Model model ) throws IOException {
+        // addVerifyPlugin?
         if ( context.isAddVerifyPlugin() ) {
-            Build build = model.getBuild();
-            if ( build == null ) {
-                build = new Build();
-                model.setBuild( build );
-            }
-            List<Plugin> plugins = model.getBuild().getPlugins();
-            Plugin plugin = new Plugin();
-            plugin.setGroupId( GROUP_ID );
-            plugin.setArtifactId( "fj-doc-maven-plugin" );
-            plugin.setVersion( "${"+KEY_VERSION+"}" );
-            PluginExecution execution = new PluginExecution();
-            execution.setId( "freemarker-verify" );
-            execution.setPhase( "compile" );
-            execution.addGoal( "verify" );
-            plugin.getExecutions().add( execution );
-            String xml = "<configuration>\n" +
-                    "      <templateBasePath>${project.basedir}/src/main/resources/"+context.getArtificatIdForFolder()+"/template</templateBasePath>\n" +
-                    "      <generateReport>true</generateReport>\n" +
-                    "      <failOnErrors>true</failOnErrors>\n" +
-                    "      <reportOutputFolder>${project.build.directory}/freemarker-syntax-verify-report</reportOutputFolder>\n" +
-                    "    </configuration>";
-            HelperIOException.apply( () -> {
-                try ( StringReader sr = new StringReader( xml ) ) {
-                    Xpp3Dom dom = Xpp3DomBuilder.build( sr );
-                    plugin.setConfiguration( dom );
+            if ( context.isVerifyPluginNotAvailable() ) {
+                log.warn( "addVerifyPlugin skipped, version {} has been selected, minimum required version is : {}", context.getVersion(), VenusContext.VERSION_NA_VERIFY_PLUGIN );
+            } else {
+                log.info( "addVerifyPlugin true, version {} has been selected, minimum required version is : {}", context.getVersion(), VenusContext.VERSION_NA_VERIFY_PLUGIN );
+                Build build = model.getBuild();
+                if ( build == null ) {
+                    build = new Build();
+                    model.setBuild( build );
                 }
-            });
-            plugins.add( plugin );
+                List<Plugin> plugins = model.getBuild().getPlugins();
+                Plugin plugin = new Plugin();
+                plugin.setGroupId( GROUP_ID );
+                plugin.setArtifactId( "fj-doc-maven-plugin" );
+                plugin.setVersion( "${"+KEY_VERSION+"}" );
+                PluginExecution execution = new PluginExecution();
+                execution.setId( "freemarker-verify" );
+                execution.setPhase( "compile" );
+                execution.addGoal( "verify" );
+                plugin.getExecutions().add( execution );
+                String xml = "<configuration>\n" +
+                        "      <templateBasePath>${project.basedir}/src/main/resources/"+context.getArtificatIdForFolder()+"/template</templateBasePath>\n" +
+                        "      <generateReport>true</generateReport>\n" +
+                        "      <failOnErrors>true</failOnErrors>\n" +
+                        "      <reportOutputFolder>${project.build.directory}/freemarker-syntax-verify-report</reportOutputFolder>\n" +
+                        "    </configuration>";
+                HelperIOException.apply( () -> {
+                    try ( StringReader sr = new StringReader( xml ) ) {
+                        Xpp3Dom dom = Xpp3DomBuilder.build( sr );
+                        plugin.setConfiguration( dom );
+                    }
+                });
+                plugins.add( plugin );
+            }
+        } else {
+            log.info( "addVerifyPlugin : false" );
         }
     }
 

fj-doc-maven-plugin/src/main/java/org/fugerit/java/doc/project/facade/VenusContext.java

@@ -17,6 +17,10 @@
 @ToString
 public class VenusContext {
 
+    public static final String VERSION_NA_VERIFY_PLUGIN = "8.7.2";
+
+    public static final String VERSION_NA_FULL_PROCESS = "8.6.2";
+
     @Getter
     private File projectDir;
 
@@ -97,8 +101,12 @@ public String getDocConfigClass() {
         return "DocHelper";
     }
 
+    public boolean isVerifyPluginNotAvailable() {
+        return VersionCheck.isMajorThan( VERSION_NA_VERIFY_PLUGIN, this.getVersion() );
+    }
+
     public boolean isPreVersion862() {
-        return VersionCheck.isMajorThan( "8.6.2", this.getVersion() );
+        return VersionCheck.isMajorThan( VERSION_NA_FULL_PROCESS, this.getVersion() );
     }
 
 }

fj-doc-maven-plugin/src/test/java/test/org/fugerit/java/doc/project/facade/TestAddVenusFacade.java

@@ -69,7 +69,7 @@ public void testMojoAdd() throws IOException, MojoExecutionException, MojoFailur
             MojoAdd mojoAdd = new MojoAdd() {
                 @Override
                 public void execute() throws MojoExecutionException, MojoFailureException {
-                    this.version = getVersion();
+                    this.version = VenusContext.VERSION_NA_VERIFY_PLUGIN;
                     this.extensions = "fj-doc-base,fj-doc-base-json,fj-doc-base-yaml,fj-doc-freemarker,fj-doc-mod-fop,fj-doc-mod-poi,fj-doc-mod-opencsv";
                     this.projectFolder = projectDir.getAbsolutePath();
                     this.addDocFacade = true;