Fix sonar issues #87

Author: fugerit79

fj-core/src/main/java/org/fugerit/java/core/xml/sax/XMLFactorySAX.java

@@ -54,7 +54,7 @@ public static XMLFactorySAX newInstanceSecure(boolean validating) throws XMLExce
         return newInstanceSecure(validating, false);
     }
 
-    public static SAXParserFactory disableExternalEntity(SAXParserFactory saxFac) throws XMLException {
+    private static SAXParserFactory disableExternalEntity(SAXParserFactory saxFac) throws XMLException {
         return XMLException.get( () -> {
             saxFac.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true);
             saxFac.setFeature("http://xml.org/sax/features/external-general-entities", false);
@@ -73,11 +73,21 @@ private static SAXParserFactory init( boolean validating, boolean namespaceAware
     }
 
     public static XMLFactorySAX newInstanceSecure(boolean validating, boolean namespaceAware) throws XMLException {
-        return new XMLFactorySAX( disableExternalEntity( init( validating, namespaceAware ) ) );
+        return newInstance( validating, namespaceAware, Boolean.TRUE );
     }
 
-    public static XMLFactorySAX newInstance(boolean validating, boolean namespaceAware) {
-        return new XMLFactorySAX( init( validating, namespaceAware ) );
+    public static XMLFactorySAX newInstance(boolean validating, boolean namespaceAware) throws XMLException {
+        return newInstance( validating, namespaceAware, Boolean.FALSE );
+    }
+
+    public static XMLFactorySAX newInstance(boolean validating, boolean namespaceAware, boolean secure) throws XMLException {
+        return XMLException.get( () -> {
+            SAXParserFactory factory = init( validating, namespaceAware );
+            if ( secure ) {
+                factory = disableExternalEntity( factory );
+            }
+            return new XMLFactorySAX( factory );
+        } );
     }
 
     public void setValidating(boolean val) {