Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing settings #771

Open
fujiapple852 opened this issue Nov 11, 2023 · 2 comments
Open

Allow changing settings #771

fujiapple852 opened this issue Nov 11, 2023 · 2 comments
Labels
enhancement New feature or request tui

Comments

@fujiapple852
Copy link
Owner

fujiapple852 commented Nov 11, 2023

The settings dialog is currently display only. It would be useful to allow some settings to be changed at runtime.

Note that any settings which influence the behaviour of the tracing algorithm (I.e the protocol) are unlikely to make sense to change on the fly and would require a backend restart anyway.

There are several settings which can be changed at runtime today via dedicated keyboard bindings.

What would the ux look like for updating config and how would that tie into existing parameter validation?

@aidan-gibson
Copy link

A program that does this pretty close to perfect is https://github.com/aristocratos/btop, I would aim to mimick how they approach settings.

@c-git
Copy link
Collaborator

c-git commented Jul 30, 2024

Thank you for the feedback, we'll have to take a look at that project once this get to the top of the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tui
Projects
None yet
Development

No branches or pull requests

3 participants