What happened
Issue #57 ('pre-commit tool auto-install silently skipped on runner') and issue #58 ('add pre-commit tool resolver and installer') both describe the same root problem: companion scripts (resolve-precommit-tools.py, install-precommit-tools.sh) were never migrated into this repo during ADR 0058 extraction, causing silent auto-install failures. PR #41 (merged Jul 8) addressed this by adding a workspace-directory fallback — when the BASH_SOURCE-relative lookup fails, the scripts fall back to ${GITHUB_WORKSPACE}/scripts/ where the reusable workflow materializes the fullsend scaffold. PR #41 also added ::warning:: annotations when companions are still missing. However, PR #41 did not reference either local issue — it only referenced upstream issues fullsend#3069 and fullsend#3070. Issue #57 is still labeled blocked (originally blocked on a fullsend CLI release that the abandoned first approach depended on). Issue #58 proposes an alternative approach (copying scripts into the repo) that may now be superseded.
What could go better
PR #41 should have referenced issues #57 and #58 since they describe the same problem in this repo. Without the cross-reference, these issues remain open and will waste triage effort. Issue #57 appears to be resolved by PR #41 (the fallback + warning directly addresses the 'silently skipped' behavior). Issue #58's approach (copying companion scripts into the repo) was an alternative to the workspace-fallback approach PR #41 chose — the team should decide whether to close it as superseded or keep it as a belt-and-suspenders hardening option. Confidence: high that #57 is addressed. Moderate uncertainty on #58 — the copy-into-repo approach has independent merit (eliminates runtime dependency on workspace setup) but may be considered unnecessary now.
Proposed change
Close issue #57 as resolved by PR #41, with a comment explaining that the workspace-fallback approach addresses the silent-skip behavior described in the issue. For issue #58, either close as superseded (if the team is satisfied with the fallback approach) or remove the blocked label and update the description to note that PR #41 provides a partial solution and #58 would add further robustness. Remove the blocked label from #57 regardless.
Validation criteria
Issues #57 and #58 have been triaged: either closed with a resolution comment referencing PR #41, or updated with current status reflecting that the workspace-fallback approach is now merged.
Generated by retro agent from #41
What happened
Issue #57 ('pre-commit tool auto-install silently skipped on runner') and issue #58 ('add pre-commit tool resolver and installer') both describe the same root problem: companion scripts (
resolve-precommit-tools.py,install-precommit-tools.sh) were never migrated into this repo during ADR 0058 extraction, causing silent auto-install failures. PR #41 (merged Jul 8) addressed this by adding a workspace-directory fallback — when theBASH_SOURCE-relative lookup fails, the scripts fall back to${GITHUB_WORKSPACE}/scripts/where the reusable workflow materializes the fullsend scaffold. PR #41 also added::warning::annotations when companions are still missing. However, PR #41 did not reference either local issue — it only referenced upstream issues fullsend#3069 and fullsend#3070. Issue #57 is still labeledblocked(originally blocked on a fullsend CLI release that the abandoned first approach depended on). Issue #58 proposes an alternative approach (copying scripts into the repo) that may now be superseded.What could go better
PR #41 should have referenced issues #57 and #58 since they describe the same problem in this repo. Without the cross-reference, these issues remain open and will waste triage effort. Issue #57 appears to be resolved by PR #41 (the fallback + warning directly addresses the 'silently skipped' behavior). Issue #58's approach (copying companion scripts into the repo) was an alternative to the workspace-fallback approach PR #41 chose — the team should decide whether to close it as superseded or keep it as a belt-and-suspenders hardening option. Confidence: high that #57 is addressed. Moderate uncertainty on #58 — the copy-into-repo approach has independent merit (eliminates runtime dependency on workspace setup) but may be considered unnecessary now.
Proposed change
Close issue #57 as resolved by PR #41, with a comment explaining that the workspace-fallback approach addresses the silent-skip behavior described in the issue. For issue #58, either close as superseded (if the team is satisfied with the fallback approach) or remove the
blockedlabel and update the description to note that PR #41 provides a partial solution and #58 would add further robustness. Remove theblockedlabel from #57 regardless.Validation criteria
Issues #57 and #58 have been triaged: either closed with a resolution comment referencing PR #41, or updated with current status reflecting that the workspace-fallback approach is now merged.
Generated by retro agent from #41