Repository navigation
Conversation
Signed-off-by: fege <fmosca@redhat.com>
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can turn on the rule miner and Qodo learns your standards from review history |
PR Summary by QodoCorrect marketplace installation and shared script documentation
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
|
🤖 Finished Review · ✅ Success · Started 5:07 PM UTC · Completed 5:23 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.58 |
|
<!-- fullsend:risk-assessment --> DetailsSmall documentation-only update with minimal blast radius, assigned moderate risk due to modifying protected path CLAUDE.md alongside recent regression history and historical change coupling on README.md. Previous run<!-- fullsend:risk-assessment --> DetailsSmall documentation-only update with minimal blast radius, assigned moderate risk due to modifying protected path CLAUDE.md alongside recent regression history and historical change coupling on README.md. Previous run (2)<!-- fullsend:risk-assessment --> DetailsSmall documentation-only update with minimal blast radius, assigned moderate risk due to modifying protected path CLAUDE.md alongside recent regression history and historical change coupling on README.md. |
ReviewFindingsHigh
Medium
Low
Next steps:
Previous run<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJtZWRpdW0iLCJjYXRlZ29yeSI6ImxvZ2ljLWVycm9yIiwiZmlsZSI6IlJFQURNRS5tZCIsImlkIjoiZl84NWY3MzBjOTYyZTQyYjAwIiwibGluZSI6NTMsImFjdGlvbmFibGUiOnRydWV9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6Im1pc3NpbmctYXV0aG9yaXphdGlvbiIsImZpbGUiOm51bGwsImlkIjoiZl80MmYxMmViMTQ4YzI1N2FmIiwiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJSRUFETUUubWQiLCJpZCI6ImZfMjljYzgzN2ZlOGQxMGQyNCIsImxpbmUiOjQzMywiYWN0aW9uYWJsZSI6ZmFsc2V9LHsic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6ImRvYy1zdHlsZSIsImZpbGUiOiJSRUFETUUubWQiLCJpZCI6ImZfYTdmNzM5ZTYyZThlOTJiNCIsImxpbmUiOjM5MSwiYWN0aW9uYWJsZSI6ZmFsc2V9XSwiZGlzcG9zaXRpb25zIjpbeyJpZCI6ImZfNDJmMTJlYjE0OGMyNTdhZiIsInN0YXR1cyI6Im9wZW4ifV19 --> ReviewFindingsHigh
Medium
Low
Next steps:
Previous run (2)<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJhY3Rpb24iOiJyZXF1ZXN0LWNoYW5nZXMiLCJmaW5kaW5ncyI6W3sic2V2ZXJpdHkiOiJsb3ciLCJjYXRlZ29yeSI6Im1pc3NpbmctYXV0aG9yaXphdGlvbiIsImZpbGUiOiJSRUFETUUubWQiLCJpZCI6ImZfNDJmMTJlYjE0OGMyNTdhZiIsImFjdGlvbmFibGUiOmZhbHNlfV19 --> ReviewFindingsHigh
Low
Labels: Documentation-only change to README, CLAUDE.md and CONTRIBUTING.md. Next steps:
|
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fullsend-ai-review
Bot
added
the
kind/documentation
|
🤖 Finished Review · ✅ Success · Started 9:26 AM UTC · Completed 9:33 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.23 |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🤖 Finished Review · ✅ Success · Started 11:09 AM UTC · Completed 11:17 AM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5-5 · Effort: high · Cost: $1.36 |
| uv sync --extra dev | ||
| ``` | ||
| The marketplace install copies the plugin into Claude Code's plugin cache and makes the skills available. | ||
| The test-plan skills install their Python dependencies on first run. |
There was a problem hiding this comment.
[medium] logic-error
The new text says "The test-plan skills install their Python dependencies on first run." with no exception, but /test-plan-ui-verify does not install its own dependencies: skills/test-plan-ui-verify/README.md tells users to run pip install playwright && playwright install chromium, the ui-verify scripts print an error and stop when Playwright is missing, and the root pyproject.toml has no playwright dependency. The PR body states the exception "(except /test-plan-ui-verify)", but it did not make it into README.md, so marketplace users following the install instructions cannot run UI verification without extra setup.
Suggested fix: Add an exception for /test-plan-ui-verify to the first-run dependency sentence and point to the prerequisites in skills/test-plan-ui-verify/README.md.
| │ ├── README.md | ||
| │ └── SKILL.md | ||
| │ ├── SKILL.md | ||
| │ └── scripts/ # Playwright-based browser automation (own scripts) |
There was a problem hiding this comment.
[low] doc-style
In the skills directory tree, the inline comment on the test-plan-ui-verify scripts/ entry starts one column to the right of the other skill comments (e.g. SKILL.md # Main orchestration skill).
Suggested fix: Remove one space before # on that line so it aligns with the other comments.
| ├── discover_feature_dir.py # Read and validate the saved feature output-dir marker | ||
| ├── ensure_feature_test_dir.py # Find or create a feature package under the component test directory | ||
| ├── get_component_test_dir.py # Map TestPlan.md components to a target-repository test directory | ||
| ├── get_filtered_tcs.py # Filter test cases for implementation |
There was a problem hiding this comment.
[low] doc-style
Inline comments in the scripts directory tree are not aligned: several newly added entries (get_filtered_tcs.py, get_framework.py, load_calibration.py, load_test_context.py, parse_skill_args.py) put the comment one column left of most entries.
Suggested fix: Align the inline comments in the scripts tree to a single column.
Summary
Docs-only fix for the marketplace install instructions and stale symlink claims.
cd ~/.claude/plugins/test-plan && uv sync --extra devstep pointedat a path that doesn't exist (marketplace installs live in a versioned plugin cache) and
wasn't needed — the skills bootstrap their own dependencies on first run (except
/test-plan-ui-verify). Install block is now terminal-onlyclaude plugincommands,with the in-Claude-Code
/plugin installnoted as an alternative.skills/_common/; skills reach theplugin-root
scripts/via relative paths (${CLAUDE_SKILL_DIR}/../../scripts/...).Corrected in README.md, CLAUDE.md (one sentence, rationale only — no governance content),
and CONTRIBUTING.md (one table cell).
entries); source-of-truth disclaimer extended to the whole tree.
No tracking issue — this description is the stated scope.
No tests affected (docs-only).