Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import not working due to actions.html.twig renamed in kimai2 base-project #2

Open
ionics opened this issue Dec 3, 2019 · 5 comments

Comments

@ionics
Copy link

ionics commented Dec 3, 2019

actions.html.twig got removed in kimai2

request.CRITICAL: Uncaught PHP Exception Twig\Error\LoaderError: "Unable to find template "macros/actions.html.twig"

@yehudahkay
Copy link

yehudahkay commented Dec 5, 2019

It is possible to fix by updating to user/actions.html.twig in the templates

@ionics
Copy link
Author

ionics commented Dec 5, 2019

as yehudahkay statet: just replace in file: /kimai2/var/plugins/ReadOnlyAccessBundle/Resources/views/showCustomerTimes.html.twig
-{% import "macros/actions.html.twig" as actions %}
+{% import "user/actions.html.twig" as actions %}

seems file has moved...
lets keep this BUG open until project owner can update the issue.

@rafaelgou
Copy link

See #4 . Actually the macro is not used, can be removed.

Here's a pull request:#5

@stephankellermayr
Copy link
Contributor

I think it should be {% import "activity/actions.html.twig" as actions %}, but it is not required and {% import "macros/toolbar.html.twig" as toolbar %} can be removed too in index.html.twig and showCustomerTimes.twig.html.
Created another PR, @fungus75 please merge this!

@fungus75
Copy link
Owner

Hi @stephankellermayr , just merged your PR.
Guess this issue is fixed by now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants