Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic tether attachment #76

Open
reactable opened this issue May 3, 2016 · 3 comments
Open

Dynamic tether attachment #76

reactable opened this issue May 3, 2016 · 3 comments

Comments

@reactable
Copy link

This explains the issue:

image

Here's the code from DropbDownMenu.js :

if (this.props.tether) {
        return ReactTether((ref$ = import$({}, this.props.tetherProps), ref$.options = {
          attachment: "top left",
          targetAttachment: "bottom left",
          constraints: [{
            to: 'scrollParent'
          }]

I'd like to redo this but unsure of what tradeoffs have been made. Is this a planned feature or do you have any thoughts on how to do it?

@furqanZafar
Copy link
Owner

yea this is planned for future, PR's are welcome though

@reactable
Copy link
Author

I'm seeing that tether-props might be able to do this. Suggestion: call it tetherProps ...

trying to modify now..

@reactable
Copy link
Author

#77 shows the issue but doesn't solve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants