Skip to content

Commit 8411412

Browse files
committed
[msi] Fix "Change destination folder" not working with new WiX.
wixtoolset/issues#9142
1 parent 55ebf6a commit 8411412

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

win32/setup/fut.wxs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<WixVariable Id="WixUIBannerBmp" Value="banner.png" />
2323
<UIRef Id="WixUI_Common" />
2424
<UI Id="MyWixUI_InstallDir">
25-
<!-- customized WixUI_FeatureTree from Wix 4.0 - my changes commented -->
25+
<!-- customized WixUI_FeatureTree from Wix 6.0.1 - my changes commented -->
2626
<TextStyle Id="WixUI_Font_Normal" FaceName="Tahoma" Size="8" />
2727
<TextStyle Id="WixUI_Font_Bigger" FaceName="Tahoma" Size="12" />
2828
<TextStyle Id="WixUI_Font_Title" FaceName="Tahoma" Size="9" Bold="yes" />
@@ -40,8 +40,6 @@
4040
<DialogRef Id="ProgressDlg" />
4141
<DialogRef Id="ResumeDlg" />
4242
<DialogRef Id="UserExit" />
43-
<!-- <Publish Dialog="BrowseDlg" Control="OK" Event="DoAction" Value="WixUIValidatePath" Order="3" /> -->
44-
<!-- <Publish Dialog="BrowseDlg" Control="OK" Event="SpawnDialog" Value="InvalidDirDlg" Order="4" Condition="NOT WIXUI_DONTVALIDATEPATH AND WIXUI_INSTALLDIR_VALID&lt;&gt;&quot;1&quot;" /> -->
4543

4644
<Publish Dialog="ExitDialog" Control="Finish" Event="EndDialog" Value="Return" Order="999" />
4745

@@ -52,12 +50,13 @@
5250
<Publish Dialog="MyLicenseAgreementDlg" Control="Next" Event="NewDialog" Value="InstallDirDlg" />
5351

5452
<Publish Dialog="InstallDirDlg" Control="Back" Event="NewDialog" Value="MyLicenseAgreementDlg" />
55-
<Publish Dialog="InstallDirDlg" Control="Next" Event="SetTargetPath" Value="[WIXUI_INSTALLDIR]" Order="1" />
56-
<!-- <Publish Dialog="InstallDirDlg" Control="Next" Event="DoAction" Value="WixUIValidatePath" Order="2" Condition="NOT WIXUI_DONTVALIDATEPATH" /> -->
57-
<!-- <Publish Dialog="InstallDirDlg" Control="Next" Event="SpawnDialog" Value="InvalidDirDlg" Order="3" Condition="NOT WIXUI_DONTVALIDATEPATH AND WIXUI_INSTALLDIR_VALID&lt;&gt;&quot;1&quot;" /> -->
58-
<Publish Dialog="InstallDirDlg" Control="Next" Event="NewDialog" Value="VerifyReadyDlg" Order="4" Condition="WIXUI_DONTVALIDATEPATH OR WIXUI_INSTALLDIR_VALID=&quot;1&quot;" />
53+
<Publish Dialog="InstallDirDlg" Control="Next" Event="SetTargetPath" Value="[WIXUI_INSTALLDIR]" Order="3" />
5954
<Publish Dialog="InstallDirDlg" Control="ChangeFolder" Property="_BrowseProperty" Value="[WIXUI_INSTALLDIR]" Order="1" />
6055
<Publish Dialog="InstallDirDlg" Control="ChangeFolder" Event="SpawnDialog" Value="BrowseDlg" Order="2" />
56+
57+
<Publish Dialog="BrowseDlg" Control="OK" Event="SetTargetPath" Value="[_BrowseProperty]" Order="3" />
58+
<Publish Dialog="BrowseDlg" Control="OK" Event="EndDialog" Value="Return" Order="4" />
59+
6160
<Publish Dialog="VerifyReadyDlg" Control="Back" Event="NewDialog" Value="InstallDirDlg" Order="1" Condition="NOT Installed" />
6261
<Publish Dialog="VerifyReadyDlg" Control="Back" Event="NewDialog" Value="MaintenanceTypeDlg" Order="2" Condition="Installed AND NOT PATCH" />
6362
<Publish Dialog="VerifyReadyDlg" Control="Back" Event="NewDialog" Value="WelcomeDlg" Order="2" Condition="Installed AND PATCH" />
@@ -69,10 +68,11 @@
6968
<Publish Dialog="MaintenanceTypeDlg" Control="Back" Event="NewDialog" Value="MaintenanceWelcomeDlg" />
7069

7170
<Property Id="ARPNOMODIFY" Value="1" />
71+
7272
<Dialog Id="MyLicenseAgreementDlg" Width="370" Height="270" Title="!(loc.LicenseAgreementDlg_Title)">
7373
<Control Id="BannerBitmap" Type="Bitmap" X="0" Y="0" Width="370" Height="44" TabSkip="no" Text="!(loc.LicenseAgreementDlgBannerBitmap)" />
74-
<Control Id="BannerLine" Type="Line" X="0" Y="44" Width="370" Height="0" />
75-
<Control Id="BottomLine" Type="Line" X="0" Y="234" Width="370" Height="0" />
74+
<Control Id="BannerLine" Type="Line" X="0" Y="44" Width="373" Height="0" />
75+
<Control Id="BottomLine" Type="Line" X="0" Y="234" Width="373" Height="0" />
7676
<Control Id="Description" Type="Text" X="25" Y="23" Width="340" Height="15" Transparent="yes" NoPrefix="yes" Text="!(loc.LicenseAgreementDlgDescription)" />
7777
<Control Id="Title" Type="Text" X="15" Y="6" Width="200" Height="15" Transparent="yes" NoPrefix="yes" Text="!(loc.LicenseAgreementDlgTitle)" />
7878
<!-- removed the checkbox and the "Print" button, replaced the "Next" button with "I Accept" -->

0 commit comments

Comments
 (0)