Skip to content
This repository was archived by the owner on Mar 31, 2023. It is now read-only.

[RM] getSubnetRouteTable in RouterServiceImpl.java should separate Neutron and VPC router scenario. #647

Open
cj-chung opened this issue Jun 23, 2021 · 3 comments
Open

[RM] getSubnetRouteTable in RouterServiceImpl.java should separate Neutron and VPC router scenario. #647

cj-chung opened this issue Jun 23, 2021 · 3 comments
Assignees
@kevin-zhonghao
Labels
bug Something isn't working
Milestone
Version 0.19.2021...

Comments

@cj-chung
Copy link
Contributor

Issue:
getSubnetRouteTable in RouterServiceImpl.java is used by both Neutron and VPC scenarios, but it's only deal with VPC scenario in the code.

Suggestion:
Add a flag as an input argument in getSubnetRouteTable to indicate the caller's scenario (Neutron or VPC).
@xieus
Copy link
Contributor

xieus commented Jun 23, 2021

@DavidLiu506 Could you also take on this fix as well as Issue #646? Thanks.

@xieus xieus added the bug Something isn't working label Jun 23, 2021
@xieus xieus added this to the Version 0.17.2021.07.30 milestone Jun 23, 2021
@kevin-zhonghao kevin-zhonghao mentioned this issue Jun 30, 2021
Closed
@xieus
Copy link
Contributor

xieus commented Jun 30, 2021

@kevin-zhonghao Can you also take a look at this issue? Thanks!

@kevin-zhonghao
Copy link
Contributor

@kevin-zhonghao Can you also take a look at this issue? Thanks!

Sure, fix in PR#657

@xieus xieus assigned kevin-zhonghao and unassigned DavidLiu506 Jun 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kevin-zhonghao kevin-zhonghao

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 0.19.2021.09.30
Development

No branches or pull requests
4 participants
@xieus @kevin-zhonghao @cj-chung @DavidLiu506