Pre-commit failing when run against all files

[proudfeet]

Hey!

(Can't see an issue template so apologies if this isn't the format you would prefer).

When experimenting locally I noticed that some of the pre-commit hooks are failing when run against all files.
Nothing major at all, just thought I would flag them so you get greens across the board on your checks.

Environment

• OS: Ubuntu 20.04
• Python version: 3.10.5 (through pyenv as per developer setup)

Description of the problem

Running pre-commit (as per command below) against the develop branch, across all files, results in failures.

Command:

pre-commit run --all-files

Failures are for the typo and mypy hooks.

typo
The failures here appear to be a simple config issue. Which is being tracked here.

A temporary solution is to add pass_filenames: false to the hook.

mypy
The failure here appears to be due to some historic type ignore comments on the requests_html lib. I assume they have added typing (very nice of them) at some point since you started using pre-commit.

Solution

Happy to put in PR with these small changes.

(Also noticed some of the pre-commit hooks could do with updating, I will put that in as a separate issue and PR to keep things clean).