Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormLayout calls MinSize twice #4900

Open
2 tasks done
dweymouth opened this issue Jun 2, 2024 · 0 comments
Open
2 tasks done

FormLayout calls MinSize twice #4900

dweymouth opened this issue Jun 2, 2024 · 0 comments
Labels
optimization Tickets that could help Fyne apps run faster

Comments

@dweymouth
Copy link
Contributor

Checklist

  • I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
  • This issue only relates to a single bug. I will open new issues for any other problems.

Describe the bug

When #4821 was closed out FormLayout moved away from allocating in every MinSize/Layout call, but introduced new behavior that MinSize is called twice per object instead of once. We can do a small form optimization where a table is stack-allocated for small forms with less than say 16 rows, and the old algorithm can be used.

How to reproduce

n/a

Screenshots

No response

Example code

n/a

Fyne version

develop

Go compiler version

n/a

Operating system and version

n/a

Additional Information

No response

@dweymouth dweymouth added the optimization Tickets that could help Fyne apps run faster label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Tickets that could help Fyne apps run faster
Projects
None yet
Development

No branches or pull requests

1 participant