Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop printing diffs between failed image matches #4977

Open
2 tasks done
Jacalz opened this issue Jun 25, 2024 · 0 comments
Open
2 tasks done

Stop printing diffs between failed image matches #4977

Jacalz opened this issue Jun 25, 2024 · 0 comments
Labels
enhancement New feature or request testing Issues related to tests and testing.

Comments

@Jacalz
Copy link
Member

Jacalz commented Jun 25, 2024

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

When image tests are failing, the assert.Equal call prints a massive stream of both all of the uint8{} pixel values but also a diff between the images which results in a total flooding of the terminal. I find the output to be not all that helpful but also distracting as it is hard to see which tests are failing.

Is it possible to construct a solution with the existing API?

Should be possible to just stop using assert.Equal for anything else than SVG but I had problems doing this change due to weird issues related to #4976.

Describe the solution you'd like to see.

No diff for failing images matches when the image is anything different than an SVG.

@Jacalz Jacalz added enhancement New feature or request testing Issues related to tests and testing. labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing Issues related to tests and testing.
Projects
None yet
Development

No branches or pull requests

1 participant