Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experience Bush cannot be harvested by Create Mechanical Harvester #132

Open
cha0s5150 opened this issue Dec 13, 2023 · 6 comments
Open

Comments

@cha0s5150
Copy link

As the title says, I am running Create and Amethyst Imbuement on my server. The mechanical harvester cannot harvest the experience bush, but it can harvest the Sweet Berry Bush right next to it.
I am using Fabric 1.20.1

I can provide any other information you might need on request.

@fzzyhmstrs
Copy link
Owner

Thank you very much for the report. I have a couple leads on what I can do on my end, but there may also be some issues with Creates end that are stopping things. I'll take a closer look

@cha0s5150
Copy link
Author

Thanks for the quick response time.

@JustinQ-Personal
Copy link

I have the same issue, however if you want a quick fix, using a deployer from the create mod instead of a harvester works

@Tundrin
Copy link

Tundrin commented Mar 22, 2024

Have been dealing with the same issue, and I just noticed something that may be related. When you break a fully grown exp bush it only drops the berry, not the exp bottles you would get by right clicking it. From a quick look at the create code it seems that the harvester breaks the crop and then sets it back to it's CanSurvive state (maybe? not 100% sure).

So, it seems like there's actually 2 issues to be resolved here, firstly that breaking the grown bush doesn't give exp bottles and secondly getting Create to replant the bush in the correct state. I think fixing the first issue should be pretty simple, and that would at least allow the farms to be functional even if they'd be less efficient than they should.

Edit: Aaaaand nevermind, you literally already did that. ignore me...

@fzzyhmstrs
Copy link
Owner

the latest AI updates add the bottles to the loot table, so that should be resolved. From the investigation I made, there is a part of the Create code that hardcodes to exactly the block Blocks.SWEET_BERRY_BUSH, which obviously won't work for bushes that aren't that.

code permalink: https://github.com/Fabricators-of-Create/Create/blob/9604d98d4657caa03c798eecd07ff8f6dcb45bb7/src/main/java/com/simibubi/create/content/contraptions/actors/harvester/HarvesterMovementBehaviour.java#L193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants